Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gemspec versions #109

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Update Gemspec versions #109

merged 6 commits into from
Jul 22, 2024

Commits on Jul 22, 2024

  1. Update Gemspec versions 

    There's no reason to block pessimistically (`~>`) to any of these versions. Also add dependencies (bigdecimal) which is warned about in a deprecation warning:

```
/Users/rschneeman/.gem/ruby/3.3.1/gems/get_process_mem-0.2.7/lib/get_process_mem.rb:2: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of get_process_mem-0.2.7 to add bigdecimal into its gemspec.
```
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    5d292e5 View commit details
    Browse the repository at this point in the history

  2. Switch to testing on modern Ruby versions 

    This doesn't directly mean that these versions won't work, but we no longer make claims about their support.
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a611cc4 View commit details
    Browse the repository at this point in the history

  3. Changelog

    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    1d3afcf View commit details
    Browse the repository at this point in the history

  4. Switch to standardrb for linting

    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    c112f7a View commit details
    Browse the repository at this point in the history

  5. Apply standard linting styles 

    ```
$ be standardrb --fix
standard: Use Ruby Standard Style (https://github.com/standardrb/standard)
  lib/puma_worker_killer/puma_memory.rb:78:20: Style/HashConversion: Prefer ary.to_h to Hash[ary].
standard: Run `standardrb --fix-unsafely` to DANGEROUSLY fix one problem.
```
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    df449aa View commit details
    Browse the repository at this point in the history

  6. Fix uninitialized warning 

    ```
/Users/rschneeman/Documents/projects/puma_worker_killer/puma_worker_killer.gemspec:17: warning: global variable `$INPUT_RECORD_SEPARATOR' not initialized
```
    @schneems
    schneems committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d7bb88d View commit details
    Browse the repository at this point in the history