Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO: Implement users table user invite revoking [Original] #35272

Closed
wants to merge 24 commits into from

Conversation

agrullon95
Copy link
Contributor

@agrullon95 agrullon95 commented Jan 26, 2024

Fixes #

Proposed changes:

CleanShot 2024-01-25 at 22 49 56@2x

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. On an Atomic, JN, or whatever non-simple site, install Jetpack.
  2. Make sure SSO is on, it should be on by default.
  3. Sync this PR to your site.
  4. Go to the users table (wp-admin/users/php).
  5. It should have the status of the user's connection "Connected", "Invite", or "Pending invite".
  6. Clicking "Invite" should invite the user and change their status to "Pending invite".
  7. If you haven't already, add and invite a few new users to your site.
  8. Hover the row actions and verify that rows with 'pending invite' only display the Revoke invite action.
  9. Verify the 'Revoke invite' row action successfully revokes a user's site invitation.

@agrullon95 agrullon95 added the DO NOT MERGE don't merge it! label Jan 26, 2024
@agrullon95 agrullon95 self-assigned this Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/users-table-revoke-invite branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/users-table-revoke-invite
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for March 5, 2024 (scheduled code freeze on March 4, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 26, 2024
@alshakero alshakero force-pushed the add/users-table-revoke-invite branch from 39f561f to 8dbe8a2 Compare January 26, 2024 11:40
@alshakero alshakero changed the base branch from trunk to implement/users-table-improvements January 26, 2024 11:41
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Really clean.

projects/plugins/jetpack/modules/sso.php Outdated Show resolved Hide resolved
projects/plugins/jetpack/modules/sso.php Show resolved Hide resolved
projects/plugins/jetpack/modules/sso.php Outdated Show resolved Hide resolved
projects/plugins/jetpack/modules/sso.php Show resolved Hide resolved
@alshakero alshakero mentioned this pull request Jan 26, 2024
3 tasks
@agrullon95 agrullon95 changed the base branch from implement/users-table-improvements to add/sso-improvements January 26, 2024 15:23
@crisbusquets
Copy link
Contributor

I'll check this now, @agrullon95!

@agrullon95 agrullon95 changed the title SSO: Implement users table user invite revoking SSO: Implement users table user invite revoking [Original] Jan 26, 2024
@alshakero alshakero marked this pull request as draft January 26, 2024 21:33
Base automatically changed from add/sso-improvements to trunk February 16, 2024 12:41
@escapemanuele
Copy link
Contributor

Is it ok to close this @agrullon95 ?

@agrullon95
Copy link
Contributor Author

Is it ok to close this @agrullon95 ?

@escapemanuele - Yes, im closing this now.

@agrullon95 agrullon95 closed this Mar 25, 2024
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE don't merge it! [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants