Social: Use connections REST endpoint for initial state #40677

manzoorwanijk · 2024-12-19T05:36:51Z

Supercedes #40589

Proposed changes:

Create Automattic\Jetpack\Publicize\Connections class to handle caching for connections
Update script data to use the cached call for connections initial state

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Goto connections management on a Jetpack site and verify that everything works same as before like adding, removing and updating connections.
Apply this PR to your sandbox
Point the public API and your simple site to your sandbox
On that Simple site, goto the editor and open the Jetpack sidebar
Verify that the connections management links still point to Calypso connections management
Reset your sandbox - jetpack-downloader reset jetpack
Checkout the enterprise git PR Automattic/wpcom/pull/168243 (git checkout arcpatch-D168243) in your sandbox
Apply this PR again on top arcpatch-D168243 branch
Reload and goto the editor again and open the Jetpack sidebar
Verify that Connections management now opens the modal, instead of pointing to Calypso
In the modal, confirm that the connections show up fine.
Note that adding/removing connections is not yet implemented for simple sites

github-actions · 2024-12-19T05:37:41Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/unify-social-connections-schema branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/unify-social-connections-schema

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-12-19T05:37:46Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

gmjuhasz

Works as expected 👍

manzoorwanijk · 2024-12-19T12:20:21Z

projects/packages/publicize/src/class-publicize-base.php

-		if ( 'mastodon' === $service_name && isset( $cmeta['external_name'] ) ) {
-			return $cmeta['external_name'];
+		if ( 'mastodon' === $service_name && isset( $cmeta['external_display'] ) ) {
+			return $cmeta['external_display'];


We want to have @[email protected] instead of just jetpack_reach

gmjuhasz

Still works

* Create connections class for caching * Update script data to use connections from the REST endpoint * changelog * Restore deprecated connection fields for time being * Disable caching for now * Fix display_name for Mastodon * Remove the unused caching logic

manzoorwanijk added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review labels Dec 19, 2024

manzoorwanijk requested a review from a team December 19, 2024 05:36

manzoorwanijk self-assigned this Dec 19, 2024

manzoorwanijk mentioned this pull request Dec 19, 2024

Social | Standardize connections API schema #40589

Closed

3 tasks

github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [Package] Publicize labels Dec 19, 2024

manzoorwanijk mentioned this pull request Dec 19, 2024

Social: Connections API schema front end changes #40539

Open

3 tasks

manzoorwanijk added the DO NOT MERGE don't merge it! label Dec 19, 2024

manzoorwanijk added 3 commits December 19, 2024 13:59

Create connections class for caching

33936fa

Update script data to use connections from the REST endpoint

6a63224

changelog

d1762a9

manzoorwanijk force-pushed the update/unify-social-connections-schema branch from 1adc9a8 to d1762a9 Compare December 19, 2024 08:29

manzoorwanijk changed the base branch from trunk to social/unified-connections-management December 19, 2024 08:29

manzoorwanijk removed the DO NOT MERGE don't merge it! label Dec 19, 2024

gmjuhasz approved these changes Dec 19, 2024

View reviewed changes

manzoorwanijk added 3 commits December 19, 2024 17:48

Restore deprecated connection fields for time being

e3efa9b

Disable caching for now

fb0f012

Fix display_name for Mastodon

f6b41d7

manzoorwanijk commented Dec 19, 2024

View reviewed changes

Remove the unused caching logic

a71f39c

gmjuhasz approved these changes Dec 20, 2024

View reviewed changes

manzoorwanijk merged commit d6b615d into social/unified-connections-management Dec 20, 2024
56 checks passed

manzoorwanijk deleted the update/unify-social-connections-schema branch December 20, 2024 09:42

github-actions bot removed the [Status] Needs Team Review label Dec 20, 2024

manzoorwanijk restored the update/unify-social-connections-schema branch December 20, 2024 10:56

manzoorwanijk deleted the update/unify-social-connections-schema branch December 20, 2024 10:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social: Use connections REST endpoint for initial state #40677

Social: Use connections REST endpoint for initial state #40677

manzoorwanijk commented Dec 19, 2024

github-actions bot commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 19, 2024

gmjuhasz left a comment

manzoorwanijk Dec 19, 2024

gmjuhasz left a comment

Social: Use connections REST endpoint for initial state #40677

Social: Use connections REST endpoint for initial state #40677

Conversation

manzoorwanijk commented Dec 19, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Dec 19, 2024 • edited Loading

github-actions bot commented Dec 19, 2024

gmjuhasz left a comment

Choose a reason for hiding this comment

manzoorwanijk Dec 19, 2024

Choose a reason for hiding this comment

gmjuhasz left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024 •

edited

Loading