-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to deploy-dev.yml to save all workflow artifacts including do… #400
Conversation
- name: Upload Docker Build Artifact | ||
if: ${{ steps.image_check.outputs.docker_inspect == 1 }} | ||
uses: actions/upload-artifact@v3 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal here to provide access to the docker image after it's been built? If so we are pushing our images once they're built to https://github.com/CDCgov/ReportVision/pkgs/container/reportvision-ocr-api and we are doing this at .github/actions/build-publish-api
. Once that image is published to the GH registry, the azure/webapps-deploy@v3
action uses it here:
images: '${{ inputs.docker-registry }}/${{ env.REPO}}-${{ inputs.api-name }}:${{ inputs.docker-tag }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we could possibly think of doing is migrating our registry to something like ACR instead. The main con however to doing that would be if this system ever needs to be cloud agnostic in the future, which it most likely would need to be.
Deprioritized. |
…ckerbuild
Description
[Provide a brief description of the changes implemented in this pull request.]
Screenshots (if applicable)
Related Issues
[Link any related issues or tasks from your project management system.]
Checklist