Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024-12-08 update : changing center of prior. #260

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

cbernalz
Copy link
Collaborator

@cbernalz cbernalz commented Dec 8, 2024

Regarding #259 (comment) .

@cbernalz cbernalz self-assigned this Dec 8, 2024
@cbernalz cbernalz marked this pull request as ready for review December 8, 2024 23:58
@cbernalz cbernalz requested a review from kaitejohnson December 8, 2024 23:58
@kaitejohnson
Copy link
Collaborator

@cbernalz Could you provide a comparison of the posterior estimates of the phi parameter with both priors from the fit to the exponential and the data generated from the exponential? Ideally a density plot or histogram with the priors and posteriors overlaid

I am curious if with either of the prior values, the posterior estimate of the true phi is identifiable -- since this is generated with simulated data we know this.

After doing that check, I would also consider increasing phi in the generation of the simulated data above, this way the strength of the correlation as a function of distance is increased in your simulation analysis

@cbernalz
Copy link
Collaborator Author

@cbernalz Could you provide a comparison of the posterior estimates of the phi parameter with both priors from the fit to the exponential and the data generated from the exponential? Ideally a density plot or histogram with the priors and posteriors overlaid

I am curious if with either of the prior values, the posterior estimate of the true phi is identifiable -- since this is generated with simulated data we know this.

After doing that check, I would also consider increasing phi in the generation of the simulated data above, this way the strength of the correlation as a function of distance is increased in your simulation analysis

@kaitejohnson Here is the plot that results from the prior and posterior for $\phi$. The old prior is centered at 0.25 with sd 0.75. The new prior is centered at 1 with sd 0.4. The actual value is 1.5.
IMG_7814

@kaitejohnson
Copy link
Collaborator

This looks reasonable to me! Model seems to struggle in both cases a bit with identifiability but this makes sense -- between the R(t) variability and lab-site level observation noise there are a lot of drivers of variation in C(t).

Copy link
Collaborator

@kaitejohnson kaitejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaitejohnson kaitejohnson merged commit 77c941a into spatial-main Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants