[HOLD for payment 2024-05-02] CRITICAL: [P2P Distance] [$500] Create a new Rate field

[neil-marcellini]

Create a new Rate field following this plan. Please be sure to read and understand the relevant sections of the entire plan as well.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184867e0f5e71241a
• Upwork Job ID: 1760135995824672768
• Last Price Increase: 2024-02-21
• Automatic offers:
• getusha | Reviewer | 0

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0184867e0f5e71241a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[neil-marcellini]

@koko57 would you please reply to this comment so I can assign you to implement this issue? It's the largest piece of the front end implementation so I would like you to implement it, since you wrote the front end design and know it better than anyone else 🙂

[koko57]

Taking this one! 😃

[melvin-bot]

📣 @getusha 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[neil-marcellini]

How's this coming along? It's still a bit of a ways out, so no rush, just curious.

[koko57]

Most of the UI done 😃 Same with the util functions (the one for getting the Rate for P2P will probably need to be changed a bit, I used mock data now). I will leave a detailed summary what is already done and what has to be done today EOD. I will push my changes on the branch so it can be taken over if necessary while I'm ooo.

[koko57]

Pasting all the required steps for this issue with the current status:

• Create a util function DistanceRequestUtils.getDistanceForDisplay [or refactor getDisplayMerchant]
  -> done
• Create a util function DistanceRequestUtils.getRateForP2P
  -> started working on it - it will probably need to be changed when the default rates will be implemented in the App
• Create a util function DistanceRequestUtils.getRateForDisplay
  -> done
• Create a function DistanceRequestUtils.getMileageRates
  -> done, only needs some TS fix

• Create new Rate field UI
  -> UI: done

  TODO:

• use canUseP2PDistanceRequests from usePermissions to display old distance / rate field or new distance and new rate field (now I hardcoded it as a boolean) ON HOLD for: https://github.com/Expensify/App/pull/37185

• use rate from mileageRates with transactionDraft.comment.customUnit.customUnitRateID or get it with

DistanceRequestUtils.getRateForP2P


• Create Rate Selection page UI (with translations)

  -> partially done:

  TODO:


• Spanish translations



• Add logic for the merchant recalculation

  -> TODO:

• recalculation logic

• Create new functions in IOU utils to save the rate as NVP.LAST_SELECTED_DISTANCE_RATES and update comment.customUnit.customUnitRateID  in the transactionDraft object.

  -> started working on them, they will probably need to be changed later 

• Add Rate field to the MoneyRequestView

  -> TODO:

• UI + logic

All the partially done code has TODO comments. Changes are on this branch https://github.com/koko57/App/tree/feat/36985-create-new-rate-field

I'm leaving for the next week, I'll be back on 03/12
@neil-marcellini please let @waterim know when he should take it over

[neil-marcellini]

Thanks very much. @waterim if you could take over and continue progress on that branch while @koko57 is out, that would be great. We're getting close to enabling P2P on the backend and frontend, and this will come right after that.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Feat/36985 create new rate field followups #40711

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @koko57 does not require payment (Contractor)
• @getusha requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@getusha] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[bfitzexpensify]

Looks like there were a fair number of regressions here. @neil-marcellini, what do you think a fair payout for this job is?

[neil-marcellini]

It's not a bug, it was a new feature implemented by an expert from Callstack, and most features have some bugs initially, so I don't think we should reduce any pay for regressions. Also I believe most bugs were under a beta.

The only payment needed is for the C+ @getusha, and I think they deserve full payment.

[melvin-bot]

@shawnborton, @neil-marcellini, @koko57, @bfitzexpensify, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Thanks @neil-marcellini - @getusha, I sent you an offer for this job.

[getusha]

Accepted @bfitzexpensify, thank you all! 🙇

[bfitzexpensify]

Thanks! Payment complete, thanks for the work here everyone.