Updating shapes to use shapes.scl and fix some minor things #94
Conversation
Ghoulboy78
changed the title
There was a problem hiding this comment.
Is this working off of your suggested changes to shapes.scl in gnembon/fabric-carpet#1154? Because right now it doesn't work with the current shapes.scl. I'd also like to know it that PR depends on gnembon/fabric-carpet#1218, because as discusse on Discord, it doesn't look like perople are gonna agree on implementing your suggested changes...
Edit: I reviewed the linked PR for shapes.scl, needs some changes before it's ready. If you confirm this PR here is working off of that one, i'll intall the suggested library and test this PR again.
This is indeed working off of my changes to shapes.scl in gnembon/fabric-carpet#1154, as mentioned in the title, but gnembon/fabric-carpet#1218 has got nothing to do with this, because gnembon/fabric-carpet#1154 uses a workaround so I don't have to use it. |
|
One thing that could be done is adding the newer Carpet version in a |
|
I'm afraid I don't really know how 'requires' works, so I couldn't do it myself... |
It replaces cuboid, cylinder, sphere, cone and pyramid with shapes.scl equivalents.
Obviously it will work better when gnembon/fabric-carpet#1154 is accepted, and cuboid does actually need to be reverted and the old code fixed.