Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Basics Course: Replace Replit exercises #29161

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Eduardo06sp
Copy link
Member

@Eduardo06sp Eduardo06sp commented Dec 7, 2024

Because

we are removing Replit, so we have to replace the Replit exercises with new content from our javascript-exercises repo.

This PR

  • Adds a very simple overview of javascript-exercises with a brief explanation of return in the Data Types and Conditionals lesson
  • Adds the introductory exercise 01_helloWorld to the Data Types and Conditionals lesson
  • Replaces the Replit exercises in the Data Types and Conditional lesson
    • The new ones come from our javascript-exercises repo
    • 02_addNumbers replaces Replit exercise 1 (troubleshooting)
    • 03_numberChecker replaces Replit exercise 2 (enter a number)
    • 04_mathEquations replaces Replit exercise 3 (lets do some math)
    • 05_joinStrings replaces Replit exercise 4 (direction follow)
  • Removes introductory exercise 01_helloWorld from Arrays and Loops lesson
  • Renumbers/rewords the exercises/assignment in the Arrays and Loops lesson
  • Adds reminder to ensure that user has already completed Node.js installation, exercise set up and 01_helloWorld in the Arrays and Loops lesson
    • This is to account for moving the Installing Node.js lesson further back, in case some users were still doing lessons before they could get to Installing Node.js
  • Renumbers/rewords exercises/assignment in the Object Basics lesson

Issue

Related to #29054

Additional Information

Since multiple repos are affected simultaneously, it may be ideal to merge all 3 PRs at once:

Blockers:

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Dec 7, 2024
@Eduardo06sp
Copy link
Member Author

I will update some formatting for the Arrays and Loops lesson to match the style guide

@wise-king-sullyman wise-king-sullyman requested review from a team and thatblindgeye and removed request for a team December 10, 2024 01:57
KevinMulhern pushed a commit to TheOdinProject/theodinproject that referenced this pull request Dec 10, 2024
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
we are replacing Replit exercises with ones from `javascript-exercises`,
so we need to do set up for Node.js earlier in the JavaScripts Basics
course.

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
* Moves the Installing Node.js lesson so it is right before the Data
Types and Conditionals lesson
- The Data Types and Conditionals lesson is where we will have new
material from `javascript-exercises`

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Related to TheOdinProject/curriculum#29054

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->
Since multiple repos are affected simultaneously, it may be ideal to
merge all 3 PRs at once:

**Blockers:**
* Need to add the four new exercises to the `javascript-exercises` repo
- TheOdinProject/javascript-exercises#509
* Need to update the appropriate lessons within our `curriculum` repo to
replace the Replit lessons currently there -
TheOdinProject/curriculum#29161

I will link the relevant PRs here in a moment after I create them.

## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [ ] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant