Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Relocate Node.js installation lesson #4870

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Eduardo06sp
Copy link
Member

@Eduardo06sp Eduardo06sp commented Dec 7, 2024

Because

we are replacing Replit exercises with ones from javascript-exercises, so we need to do set up for Node.js earlier in the JavaScripts Basics course.

This PR

  • Moves the Installing Node.js lesson so it is right before the Data Types and Conditionals lesson
    • The Data Types and Conditionals lesson is where we will have new material from javascript-exercises

Issue

Related to TheOdinProject/curriculum#29054

Additional Information

Since multiple repos are affected simultaneously, it may be ideal to merge all 3 PRs at once:

Blockers:

I will link the relevant PRs here in a moment after I create them.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc
    • Fix - bug fixes
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • I have verified all tests and linters pass after making these changes.
  • If this PR addresses an open issue, it is linked in the Issue section
  • If applicable, this PR includes new or updated automated tests

@Eduardo06sp
Copy link
Member Author

yarn lint and yarn test were not working properly for me,
but I am confident that it probably won't make a difference due to the type of change I made

@MaoShizhong
Copy link
Contributor

yarn lint runs fine for me and yarn test no longer exists, and will be corrected when #4856 is completed.

@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4870 December 8, 2024 11:02 Inactive
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Eduardo06sp, this looks great to me!

I wonder if we should go a step further and move the node installation to the first spot in the JS section. I think it might flow better and avoid learners needing to context switch to an installation lesson when they are just getting started with JS.

But, I do like the idea of keeping preparation lessons like this one as close as possible to where they are useful like you have here.

Whats your thoughts?

@Eduardo06sp
Copy link
Member Author

@KevinMulhern I'm personally a huge fan of context switching in this case.

I love that you start to get into JavaScript for the first time, do a lot of reading, then you get an "easy" installation lesson next.

I just imagine a learner engaging in learning JS for the first time with a potentially huge cognitive load doing a ton of reading (which although not liked by many, is necessary). Then they just hit an installations lesson which is a much easier walkthrough that lets their brain rest. Then they continue learning more JavaScript.

This is could force a bit of spaced repetition as well, depending on rate of lesson completion.

I may be overthinking it, but this is why I would favor putting Installing Node.js right before the lesson it's used in as opposed to anywhere before that. Regardless, I absolutely would not mind making a change if you prefer the increased levels of simplicity and organization of doing installation stuff up front instead, before all of the JavaScript lessons.

@KevinMulhern
Copy link
Member

That sounds like solid reasoning to me! thanks @Eduardo06sp.

@KevinMulhern KevinMulhern merged commit efc8a99 into TheOdinProject:main Dec 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants