All exercises: Add four new exercises #509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In case you're wondering, I have gone through the new exercises myself a few times to make sure everything works as intended. I had to deviate from Replit a few times, but I tried keeping it as easy as possible for beginners. |
KevinMulhern
pushed a commit
to TheOdinProject/theodinproject
that referenced
this pull request
Dec 10, 2024
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. --> ## Because <!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. --> we are replacing Replit exercises with ones from `javascript-exercises`, so we need to do set up for Node.js earlier in the JavaScripts Basics course. ## This PR <!-- A bullet point list of one or more items describing the specific changes. --> * Moves the Installing Node.js lesson so it is right before the Data Types and Conditionals lesson - The Data Types and Conditionals lesson is where we will have new material from `javascript-exercises` ## Issue <!-- If this PR closes an open issue in this repo, replace the XXXXX below with the issue number, e.g. Closes #2013. If this PR closes an open issue in another TOP repo, replace the #XXXXX with the URL of the issue, e.g. Closes https://github.com/TheOdinProject/curriculum/issues/XXXXX If this PR does not close, but is related to another issue or PR, you can link it as above without the 'Closes' keyword, e.g. 'Related to #2013'. --> Related to TheOdinProject/curriculum#29054 ## Additional Information <!-- Any other information about this PR, such as a link to a Discord discussion. --> Since multiple repos are affected simultaneously, it may be ideal to merge all 3 PRs at once: **Blockers:** * Need to add the four new exercises to the `javascript-exercises` repo - TheOdinProject/javascript-exercises#509 * Need to update the appropriate lessons within our `curriculum` repo to replace the Replit lessons currently there - TheOdinProject/curriculum#29161 I will link the relevant PRs here in a moment after I create them. ## Pull Request Requirements <!-- Replace the whitespace between the square brackets with an 'x', e.g. [x]. After you create the PR, they will become checkboxes that you can click on. --> - [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md) - [x] The title of this PR follows the `keyword: brief description of change` format, using one of the following keywords: - `Feature` - adds new or amends existing user-facing behavior - `Chore` - changes that have no user-facing value, refactors, dependency bumps, etc - `Fix` - bug fixes - [x] The `Because` section summarizes the reason for this PR - [x] The `This PR` section has a bullet point list describing the changes in this PR - [ ] I have verified all tests and linters pass after making these changes. - [x] If this PR addresses an open issue, it is linked in the `Issue` section - [ ] If applicable, this PR includes new or updated automated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
we are removing Replit completely from the curriculum, so we need to replace the four exercises from Replit.
This PR
01_helloWorld's README to account for these new exercises.skipping tests fromrepeatStringexercise to the (new)numberCheckerexercisenumberCheckeris now the first exercise in which tests are.skippedIssue
Related to TheOdinProject/curriculum#29054
Additional Information
Since multiple repos are affected simultaneously, it may be ideal to merge all 3 PRs at once:
Blockers:
curriculumrepo to replace the Replit lessons currently there - JavaScript Basics Course: Replace Replit exercises curriculum#29161I will link the relevant PRs here in a moment after I create them.
Pull Request Requirements
location of change: brief description of changeformat, e.g.01_helloWorld: Update test casesBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection/solutionsfolder