Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pool): don't log an error during validation failure in gas check #914

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(pool): don't log an error during validation failure in gas check #914

merged 1 commit into from
Nov 25, 2024

Conversation

dancoombs
Copy link
Collaborator

No description provided.

@dancoombs dancoombs mentioned this pull request Nov 24, 2024
Merged
0xfourzerofour
0xfourzerofour previously approved these changes Nov 24, 2024
View reviewed changes
@dancoombs dancoombs force-pushed the danc/fix-pool-error-log-pick branch from 7799219 to cd1a989 Compare November 24, 2024 16:14
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.13%. Comparing base (663a373) to head (afd4a8c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/pool/src/mempool/uo_pool.rs 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
crates/pool/src/mempool/uo_pool.rs 92.09% <0.00%> (-0.06%) ⬇️
Flag Coverage Δ
unit-tests 59.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
rundler binary 0.00% <ø> (ø)
builder 65.06% <ø> (ø)
dev ∅ <ø> (∅)
pool 66.64% <0.00%> (-0.01%) ⬇️
provider 20.84% <ø> (ø)
rpc 25.87% <ø> (ø)
sim 76.76% <ø> (ø)
tasks ∅ <ø> (∅)
types 67.81% <ø> (ø)
utils 31.73% <ø> (ø)
---- 🚨 Try these New Features:

@dancoombs dancoombs force-pushed the danc/fix-pool-error-log-pick branch from cd1a989 to afd4a8c Compare November 25, 2024 15:05
@dancoombs dancoombs merged commit 6817ed7 into main Nov 25, 2024
10 checks passed
@dancoombs dancoombs deleted the danc/fix-pool-error-log-pick branch November 25, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xfourzerofour 0xfourzerofour 0xfourzerofour approved these changes

@dphilipson dphilipson Awaiting requested review from dphilipson dphilipson is a code owner

@alex-miao alex-miao Awaiting requested review from alex-miao alex-miao is a code owner

@andysim3d andysim3d Awaiting requested review from andysim3d andysim3d is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancoombs @0xfourzerofour