Fixed PPS Global Alignment paths

[MatiXOfficial]

PR description:

Fix to #38885.

• Removed commas from the paths.
• Replaced points with underscores.

PR validation:

• Workflow 1042 passes.
• Reproduced some results from https://github.com/CTPPS/pps-alignment-data.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but needs to backport to 12_4_X

[tvami]

type bugfix,ctpps

[tvami]

test parameters:

• workflows = 1042

[tvami]

urgent

• backport needed for datataking

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38930/31375

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for master.

It involves the following packages:

• CalibPPS/AlignmentGlobal (alca)
• CalibPPS/ESProducers (alca)

@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @mmusich, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bc21/26581/summary.html
COMMIT: 753dca7
CMSSW: CMSSW_12_5_X_2022-08-01-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38930/26581/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 1042.0

----- Begin Fatal Exception 01-Aug-2022 23:48:46 CEST-----------------------
An exception of category 'BadMonitorElementPathName' occurred while
   [0] Processing  stream begin Run run: 305064 stream: 0
   [1] Calling method for module PPSAlignmentWorker/'ppsAlignmentWorker'
Exception Message:
 Monitor element path name: 'AlCaReco/PPSAlignment/worker/sector 45/near_far/x slices N/5.0-5.5/h_y' uses unacceptable characters.
 Acceptable characters are: /ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-+=_()# 
----- End Fatal Exception -------------------------------------------------

[tvami]

@MatiXOfficial you need to add

std::replace(buf, buf + strlen(buf), '.', '_');  // replace . with _

to this line too:

cmssw/CalibPPS/AlignmentGlobal/plugins/PPSAlignmentWorker.cc

Line 276 in 753dca7

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38930/31377

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #38930 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70bc21/26583/summary.html
COMMIT: 16362f2
CMSSW: CMSSW_12_5_X_2022-08-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38930/26583/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1042.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-70bc21/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

• No significant changes to the logs found
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3664357
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3664315
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 213 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[ChrisMisan]

+alca

• 1042 passes
• differences only in msgLogger and MTD

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1