style(theme): change point and isolated point style and visibility #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1011615.
markov00
added
:interactions
nickofthyme
reviewed
Sep 19, 2024
packages/charts/src/chart_types/xy_chart/state/selectors/get_debug_state.ts
Show resolved
Hide resolved
nickofthyme
approved these changes
Sep 20, 2024
packages/charts/src/chart_types/xy_chart/renderer/dom/highlighter.tsx
Outdated
Show resolved
Hide resolved
packages/charts/src/chart_types/xy_chart/renderer/canvas/points.ts
Outdated
Show resolved
Hide resolved
|
buildkite update screenshots |
nickofthyme
pushed a commit
that referenced
this pull request
Sep 23, 2024
# [67.0.0](v66.1.1...v67.0.0) (2024-09-23) ### Bug Fixes * **deps:** update dependency @elastic/eui to ^95.8.0 ([#2504](#2504)) ([1ca5dd9](1ca5dd9)) * **deps:** update dependency @playwright/test to ^1.46.1 ([#2511](#2511)) ([b99b3e6](b99b3e6)) * **deps:** update dependency json-schema-to-typescript to v15.0.1 ([#2510](#2510)) ([a606d72](a606d72)) ### Styles * **theme:** change point and isolated point style and visibility ([#2525](#2525)) ([87de6c2](87de6c2)) ### BREAKING CHANGES * **theme:** the `isolatedPoint` style doesn't contain the `radius` parameter anymore. The radius is derived from the `line.strokeWidth` parameter.
Closed
3 tasks
4 tasks
markov00
added a commit
to elastic/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix #200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`; (cherry picked from commit a7397b2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`; (cherry picked from commit a7397b2)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 3, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`; (cherry picked from commit a7397b2)
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[TSVB] fix point visibility regression (#202358)](#202358) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB] fix point visibility regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[TSVB] fix point visibility regression (#202358)](#202358) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB] fix point visibility regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
kibanamachine
added a commit
to elastic/kibana
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[TSVB] fix point visibility regression (#202358)](#202358) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Vettorello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T09:27:58Z","message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:TSVB","regression","release_note:fix","Team:Visualizations","v9.0.0","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[TSVB] fix point visibility regression","number":202358,"url":"https://github.com/elastic/kibana/pull/202358","mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202358","number":202358,"mergeCommit":{"message":"[TSVB] fix point visibility regression (#202358)\n\n## Summary\r\n\r\nfix https://github.com/elastic/kibana/issues/200255\r\n\r\nThe regression was caused by a [breaking\r\nchange](elastic/elastic-charts#2525) introduced\r\nby elastic-charts around the `area.points.visible` style, that passed\r\nfrom a `boolean` to a union of `'always' | 'never' | 'auto'`;","sha":"a7397b2ce23c22e06af246eca59c32c63dc63cdb"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Marco Vettorello <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary fix elastic#200255 The regression was caused by a [breaking change](elastic/elastic-charts#2525) introduced by elastic-charts around the `area.points.visible` style, that passed from a `boolean` to a union of `'always' | 'never' | 'auto'`;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #2458
BREAKING CHANGE: There is a visual difference in the way the points are rendered and the way the style is