Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orthographic projection #1235

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

kidharb
Copy link
Contributor

@kidharb kidharb commented Jan 29, 2024

Added orthographic projection by pressing 5

@kidharb
Copy link
Contributor Author

kidharb commented Jan 29, 2024

The following tests are failing, I am investigating

168 - f3d::TestInteractionCheatsheetRaytracing (Failed)
169 - f3d::TestInteractionCheatsheetWhiteBGRaytracing (Failed)
170 - f3d::TestInteractionCheatsheetBlackBGRaytracing (Failed)
171 - f3d::TestInteractionCheatsheetScalarsRaytracing (Failed)
172 - f3d::TestInteractionNoFileCheatsheetRaytracing (Failed)

@mwestphal
Copy link
Contributor

Yes, the baselines needs to be updated surely

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.44%. Comparing base (e554e26) to head (19b6545).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1235      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +0.01%     
==========================================
  Files         146      146              
  Lines        8716     8745      +29     
==========================================
+ Hits         8405     8434      +29     
  Misses        311      311              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/user/OPTIONS.md Outdated Show resolved Hide resolved
doc/user/OPTIONS.md Outdated Show resolved Hide resolved
@mwestphal
Copy link
Contributor

There was an issue that required rewriting history. Please cherry pick your commits on f3d-app/f3d master.

@kidharb kidharb closed this Feb 11, 2024
@kidharb kidharb force-pushed the orthographic-projection branch from ac5be0d to 3f8eb1d Compare February 11, 2024 19:51
@mwestphal mwestphal reopened this Feb 11, 2024
@kidharb kidharb marked this pull request as draft February 12, 2024 06:55
@kidharb kidharb marked this pull request as ready for review February 17, 2024 20:20
@mwestphal
Copy link
Contributor

almost there @kidharb ! just a few more changes and we are good for integration :)

@mwestphal
Copy link
Contributor

Missing an update of INTERACTIONS.md

Copy link
Contributor

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes needed

application/testing/CMakeLists.txt Outdated Show resolved Hide resolved
library/src/window_impl.cxx Outdated Show resolved Hide resolved
library/src/options.cxx Show resolved Hide resolved
doc/user/INTERACTIONS.md Show resolved Hide resolved
@mwestphal
Copy link
Contributor

You need to rebase on master.

@kidharb kidharb force-pushed the orthographic-projection branch from 0cfc5d9 to 19b6545 Compare March 15, 2024 17:30
@mwestphal
Copy link
Contributor

CI is unrelated, merging.

@mwestphal mwestphal merged commit 6c8d6e3 into f3d-app:master Mar 15, 2024
37 of 39 checks passed
@kidharb kidharb deleted the orthographic-projection branch March 15, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants