-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cmake target #61
base: master
Are you sure you want to change the base?
Conversation
@victor1234 Do you know why it fails under Visual Studio? |
PR is not complete now, I need 1-2 days |
README.md
Outdated
---------------- | ||
|
||
``` | ||
cmake -DCMAKE_BUILD_TYPE=Release .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We default on release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still good to spell it out because under Windows, it must be spelt out.
README.md
Outdated
Installation (CMake) | ||
---------------- | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing "mkdir build?". Note that you can do cmake -B build ...
.
@lemire PR is in draft mode now. I'm still working. It's not ready for review. |
This is a comprehensive PR and I would like to discuss whether these changes are suitable for your project. The main goal is to create modern cmake targets that install correctly and are available through various integration methods, making it easier to use the library and build packages for it. In addition, global variables are not used in modern cmake (they are propagated to the main project when the library is integrated via Please answer these questions:
|
README.md
withCMake
integration instructionsfind_package(streamvbyte)
check toUbuntu 22.04
CI