Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create cmake target #61

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Create cmake target #61

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
83e3853
Refactor cmake, add target installation
victor1234 Apr 15, 2023
59772d4
Add cmake intallation section
victor1234 Apr 17, 2023
4fa97e5
Add find_package check to Ubuntu CI
victor1234 Apr 17, 2023
0998caf
Fix version set, replace add_definitions()
victor1234 Apr 20, 2023
873d045
Fix
victor1234 Apr 25, 2023
6ee8492
Remove old code
victor1234 Apr 25, 2023
25a6049
Set minimum cmake version to 3.12
victor1234 Apr 25, 2023
e616806
Update readme with cmake installtion section
victor1234 Apr 25, 2023
4a182a0
Add CMake integration section to readme
victor1234 Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,15 @@ zigzag_encode(mysignedints, myunsignedints, number); // mysignedints => myunsign
zigzag_decode(myunsignedints, mysignedints, number); // myunsignedints => mysignedints
```

Installation (CMake)
----------------

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing "mkdir build?". Note that you can do cmake -B build ....

cmake -DCMAKE_BUILD_TYPE=Release ..
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We default on release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good to spell it out because under Windows, it must be spelt out.

cmake --build .
sudo cmake --install .
```

Installation
----------------

Expand Down