chore: Update redis to v9 in x/go.mod #795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is not passing. Looks like we need to remove everything in the CI build matrix and support only 1.20 and 1.21. |
kamikazechaser
added a commit
that referenced
this pull request
Dec 7, 2023
Squashed commit of the following: commit 6e3656db222a3f9347ee4806ef065a1b9b01a214 Author: Mohammed Sohail <[email protected]> Date: Thu Dec 7 11:12:41 2023 +0300 pkg(x): go version update -> 1.20 commit 2931df3 Author: Amaury <[email protected]> Date: Wed Dec 6 17:47:03 2023 +0100 fix tests commit 1122780 Author: Amaury <[email protected]> Date: Wed Dec 6 16:40:32 2023 +0100 chore: Update redis to v9 in x/go.mod
|
I can't push to your fork, so I'll push your changes on top of mine which upgrades the go version directive in all modules. |
|
Sounds good, I'll close my PR then. |
hibiken
pushed a commit
that referenced
this pull request
Dec 10, 2023
Squashed commit of the following: commit 6e3656db222a3f9347ee4806ef065a1b9b01a214 Author: Mohammed Sohail <[email protected]> Date: Thu Dec 7 11:12:41 2023 +0300 pkg(x): go version update -> 1.20 commit 2931df3 Author: Amaury <[email protected]> Date: Wed Dec 6 17:47:03 2023 +0100 fix tests commit 1122780 Author: Amaury <[email protected]> Date: Wed Dec 6 16:40:32 2023 +0100 chore: Update redis to v9 in x/go.mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using asynq v0.24 with x/rate (master), I get an incompatibility issue due to redis go.mod version (v8 vs v9) at this type cast:
Fixes #790