-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speak-en-jp to switch language by speak_language rosparam and add test codes. #263
Conversation
|
f398382
to
7e2a735
Compare
…e by speak_language rosparam and add test codes
7e2a735
to
7569e95
Compare
Thanks!
I re-write the code to use
Thats nice idea!
If adequate speech string is specified from arguments, use speak-google. |
(setq speach-string-candidates (list (cons "en" speach-string-candidates)))) | ||
;; Check speak_language | ||
(let* ((lang (or (ros::get-param "speak_language") "en")) | ||
(speak-string (cdr (assoc lang speach-string-candidates :test #'string=))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me, using intern
seems suitable for this case.
12.eusgl$ (functionp (intern "SPEAK-JP"))
t
13.eusgl$ (functionp (intern "SPEAK-CN"))
nil
14.eusgl$ (functionp (intern "SPEAK-EN"))
t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is reflected on #383
(setq speak-string (cdr (assoc "en" speach-string-candidates :test #'string=))) | ||
(setq speak-func #'speak-google)) | ||
;; Check speak-xx function existence. | ||
(unless speak-func |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you can not find speak-func, use google, this is why we choose "en" instead of "english"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is reflected on #383
Add new feature for speak.l.
I'd like to switch speak-en and speak-jp online: (demos for japanese guests and english guests).
I added speak-en-jp function and usage is:
We need to write both japanese and english in speaking codes.
We can switch language by changing
speak_language
ros param.Currently this is used in hrp2 73B2 demo and I copied the function into pr2eus.