-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr2eus: add text-to-spech method to robot-interface #318
Conversation
@furushchev does google translate is not working? please also check #263, one idea is to support 'text' argument of ':speak' supports both 'string' and '((:jp . "こんにちは") (:en . "Hello"))' |
@k-okada Thank you very much for feedback!
Not working. Recently google updated their authentication policy to use request with correct header and token but gstreamer (on which
That's a good idea! One possible problem is that we cannot know which language is available at euslisp level. |
pr2eus/speak.l
Outdated
@@ -8,7 +8,8 @@ | |||
(defparameter *speak-timeout* 20) | |||
|
|||
(defun send-speak-msg (msg | |||
&key (topic-name "robotsound") (timeout *speak-timeout*) | |||
&key (topic-name "robotsound") | |||
(timeout *speak-timeout*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change may not necessary.
pr2eus/robot-interface.l
Outdated
(:speak-jp (text &rest args) | ||
"Speak japanese sentence" | ||
(apply #'speak-jp text args)) | ||
) ;; defmethod robot-interface (text-to-speech) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about add :(send-speak-msg
here and change
(defun speak-jp (text &rest args)
(warning-message 3 "Function `speak-jp` will be deprecated, please use (send *ri* :speak \"text\" :lang :ja")
(send* *ri* :speak text :lang :ja args) ;; this is dangerous, because it assumes *ri*..... is this ok? if not leave current implementation here, just to show warning message"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@k-okada Sorry for a late response.
That's indeed a good idea. I updated as followings:
- added warning message for deprecated functions
speak-jp
andspeak-en
. - move text-to-speech into
robot-interface
- call
robot-interface
method:speak-jp
internally inspeak-jp
function. (same forspeak-en
) - updated test codes
confirmed by @708yamaguchi jsk-ros-pkg/jsk_robot#866 (comment) |
Also addressed in jsk-ros-pkg/jsk_robot#833
This PR includes: