Skip to content

Add a setting to enable the notebook to take up the full width #2146

Add a setting to enable the notebook to take up the full width

Add a setting to enable the notebook to take up the full width #2146

Triggered via pull request October 22, 2024 18:05
Status Failure
Total duration 10m 41s
Artifacts 8

ui-tests.yml

on: pull_request
Matrix: ui-tests
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 4 notices
[chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered: ui-tests/test/notebook.spec.ts#L1
1) [chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ───────────────── Error: "apiRequestContext.fetch: Target page, context or browser has been closed Call log: - → POST http://localhost:8888/api/sessions?1729620890522 - user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/128.0.6613.18 Safari/537.36 - accept: */* - accept-encoding: gzip,deflate,br - accept-language: en-US - content-type: text/plain;charset=UTF-8 - cookie: username-localhost-8888=2|1:0|10:1729620887|23:username-localhost-8888|188:eyJ1c2VybmFtZSI6ICIxYzAwOWNlZDZhNTU0OGFjOTM5NTNkMjNhMzFjMDM0MyIsICJuYW1lIjogIkFub255bW91cyBLYWxlIiwgImRpc3BsYXlfbmFtZSI6ICJBbm9ueW1vdXMgS2FsZSIsICJpbml0aWFscyI6ICJBSyIsICJjb2xvciI6IG51bGx9|761f1317a6987d1fd37e04167a26e8d055c4911f388416d240885cef8886df11; _xsrf=2|83a6b509|ed6d2263f2bbf0e5b4cb68d98e3c1714|1729620887 - origin: http://localhost:8888 - referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-chromium/example.ipynb - x-xsrftoken: 2|83a6b509|ed6d2263f2bbf0e5b4cb68d98e3c1714|1729620887 - sec-ch-ua: "Chromium";v="128", "Not;A=Brand";v="24", "HeadlessChrome";v="128" - sec-ch-ua-mobile: ?0 - sec-ch-ua-platform: "Linux" - content-length: 173 " while running route callback. Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })` before the end of the test to ignore remaining routes in flight. at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
[chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View: ui-tests/test/menus.spec.ts#L47
1) [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ─────────────────── Error: Screenshot comparison failed: Expected an image 369px by 648px, received 369px by 672px. 7213 pixels (ratio 0.03 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium/opened-menu-view-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium/opened-menu-view-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View: ui-tests/test/menus.spec.ts#L47
1) [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ─────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: Expected an image 369px by 648px, received 369px by 672px. 7213 pixels (ratio 0.03 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium-retry1/opened-menu-view-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium-retry1/opened-menu-view-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page: ui-tests/test/settings.spec.ts#L45
2) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page Error: Screenshot comparison failed: 356 pixels (ratio 0.01 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-visible-chromium-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-visible-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-visible-diff.png 43 | await page.reload({ waitUntil: 'networkidle' }); 44 | await page.menu.getMenuItem(showHeaderPath); > 45 | expect(await page.screenshot()).toMatchSnapshot('top-visible.png', { | ^ 46 | maxDiffPixels: 300, 47 | }); 48 | }); at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:45:37
ui-tests (chromium)
Process completed with exit code 1.
[firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder: ui-tests/test/filebrowser.spec.ts#L28
1) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 26 | 27 | expect(toolbar.getByText('Rename')).toBeVisible(); > 28 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 29 | }); 30 | 31 | test('Select one file', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:28:41
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ──────────────────── Error: Screenshot comparison failed: Expected an image 369px by 648px, received 369px by 673px. 9721 pixels (ratio 0.04 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox/opened-menu-view-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox/opened-menu-view-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View: ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ──────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Screenshot comparison failed: Expected an image 369px by 648px, received 369px by 673px. 9721 pixels (ratio 0.04 of all image pixels) are different. Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox-retry1/opened-menu-view-actual.png Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox-retry1/opened-menu-view-diff.png 45 | const menu = await page.menu.getOpenMenu(); 46 | expect(menu).toBeDefined(); > 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase()); | ^ 48 | }); 49 | }); 50 | }); at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file: ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ──────────────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 37 | 38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => { > 39 | expect(toolbar.getByText(text)).toBeVisible(); | ^ 40 | }); 41 | }); 42 | at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39) at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders: ui-tests/test/filebrowser.spec.ts#L55
3) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ─────────── Error: expect(locator).toBeVisible() Locator: getByRole('toolbar').getByText('Delete') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 5000ms - waiting for getByRole('toolbar').getByText('Delete') 53 | expect(toolbar.getByText('Rename')).toBeHidden(); 54 | expect(toolbar.getByText('Open')).toBeHidden(); > 55 | expect(toolbar.getByText('Delete')).toBeVisible(); | ^ 56 | }); 57 | 58 | test('Select files and open', async ({ page, tmpPath }) => { at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
ui-tests (firefox)
Process completed with exit code 1.
🎭 Playwright Run Summary
1 flaky [chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ────────────────── 34 passed (1.8m)
🎭 Playwright Run Summary
1 failed [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ──────────────────── 1 flaky [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page 33 passed (2.1m)
🎭 Playwright Run Summary
2 flaky [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ─────────────────── [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── 33 passed (1.9m)
🎭 Playwright Run Summary
1 failed [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ───────────────────── 2 flaky [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ───────────────────── [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ──────────── 32 passed (2.2m)

Artifacts

Produced during runtime
Name Size
notebook-chromium-test-assets
2.41 MB
notebook-chromium-test-report
2.99 MB
notebook-chromium-updated-snapshots
313 KB
notebook-dist-2146
9.5 MB
notebook-firefox-test-assets
2.09 MB
notebook-firefox-test-report
2.67 MB
notebook-firefox-updated-snapshots
368 KB
notebook-pkgs-2146
57.5 KB