Add a setting to enable the notebook to take up the full width #2146
Annotations
5 errors and 2 notices
Update snapshots:
ui-tests/test/notebook.spec.ts#L1
1) [chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ─────────────────
Error: "apiRequestContext.fetch: Target page, context or browser has been closed
Call log:
- → POST http://localhost:8888/api/sessions?1729620890522
- user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/128.0.6613.18 Safari/537.36
- accept: */*
- accept-encoding: gzip,deflate,br
- accept-language: en-US
- content-type: text/plain;charset=UTF-8
- cookie: username-localhost-8888=2|1:0|10:1729620887|23:username-localhost-8888|188:eyJ1c2VybmFtZSI6ICIxYzAwOWNlZDZhNTU0OGFjOTM5NTNkMjNhMzFjMDM0MyIsICJuYW1lIjogIkFub255bW91cyBLYWxlIiwgImRpc3BsYXlfbmFtZSI6ICJBbm9ueW1vdXMgS2FsZSIsICJpbml0aWFscyI6ICJBSyIsICJjb2xvciI6IG51bGx9|761f1317a6987d1fd37e04167a26e8d055c4911f388416d240885cef8886df11; _xsrf=2|83a6b509|ed6d2263f2bbf0e5b4cb68d98e3c1714|1729620887
- origin: http://localhost:8888
- referer: http://localhost:8888/notebooks/test-notebook-Notebook-Title-should-be-rendered-chromium/example.ipynb
- x-xsrftoken: 2|83a6b509|ed6d2263f2bbf0e5b4cb68d98e3c1714|1729620887
- sec-ch-ua: "Chromium";v="128", "Not;A=Brand";v="24", "HeadlessChrome";v="128"
- sec-ch-ua-mobile: ?0
- sec-ch-ua-platform: "Linux"
- content-length: 173
" while running route callback.
Consider awaiting `await page.unrouteAll({ behavior: 'ignoreErrors' })`
before the end of the test to ignore remaining routes in flight.
at /home/runner/work/notebook/notebook/ui-tests/node_modules/@jupyterlab/galata/src/galata.ts:961:49
|
Test:
ui-tests/test/menus.spec.ts#L47
1) [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ───────────────────
Error: Screenshot comparison failed:
Expected an image 369px by 648px, received 369px by 672px. 7213 pixels (ratio 0.03 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium/opened-menu-view-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium/opened-menu-view-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
Test:
ui-tests/test/menus.spec.ts#L47
1) [chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ───────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
Expected an image 369px by 648px, received 369px by 672px. 7213 pixels (ratio 0.03 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium-retry1/opened-menu-view-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-chromium-retry1/opened-menu-view-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
Test:
ui-tests/test/settings.spec.ts#L45
2) [chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
Error: Screenshot comparison failed:
356 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts-snapshots/top-visible-chromium-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-visible-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-settings-Settings-Sho-cda2b-ed-after-reloading-the-page-chromium/top-visible-diff.png
43 | await page.reload({ waitUntil: 'networkidle' });
44 | await page.menu.getMenuItem(showHeaderPath);
> 45 | expect(await page.screenshot()).toMatchSnapshot('top-visible.png', {
| ^
46 | maxDiffPixels: 300,
47 | });
48 | });
at /home/runner/work/notebook/notebook/ui-tests/test/settings.spec.ts:45:37
|
Test
Process completed with exit code 1.
|
Update snapshots
1 flaky
[chromium] › test/notebook.spec.ts:24:7 › Notebook › Title should be rendered ──────────────────
34 passed (1.8m)
|
Test
1 failed
[chromium] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ────────────────────
1 flaky
[chromium] › test/settings.spec.ts:23:7 › Settings › Should be persisted after reloading the page
33 passed (2.1m)
|
Loading