Add a setting to enable the notebook to take up the full width #2146
Annotations
7 errors and 2 notices
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L28
1) [firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ──────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
26 |
27 | expect(toolbar.getByText('Rename')).toBeVisible();
> 28 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
29 | });
30 |
31 | test('Select one file', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:28:41
|
Update snapshots:
ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ────────────────────
Error: Screenshot comparison failed:
Expected an image 369px by 648px, received 369px by 673px. 9721 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox/opened-menu-view-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox/opened-menu-view-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
Test:
ui-tests/test/menus.spec.ts#L47
1) [firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
Expected an image 369px by 648px, received 369px by 673px. 9721 pixels (ratio 0.04 of all image pixels) are different.
Expected: /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts-snapshots/opened-menu-view-firefox-linux.png
Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox-retry1/opened-menu-view-actual.png
Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-menus-Notebook-Menus-Open-menu-item-View-firefox-retry1/opened-menu-view-diff.png
45 | const menu = await page.menu.getOpenMenu();
46 | expect(menu).toBeDefined();
> 47 | expect(await menu?.screenshot()).toMatchSnapshot(imageName.toLowerCase());
| ^
48 | });
49 | });
50 | });
at /home/runner/work/notebook/notebook/ui-tests/test/menus.spec.ts:47:40
|
Test:
ui-tests/test/filebrowser.spec.ts#L39
2) [firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ────────────────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
37 |
38 | ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
> 39 | expect(toolbar.getByText(text)).toBeVisible();
| ^
40 | });
41 | });
42 |
at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:39:39)
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:38:56
|
Test:
ui-tests/test/filebrowser.spec.ts#L55
3) [firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ───────────
Error: expect(locator).toBeVisible()
Locator: getByRole('toolbar').getByText('Delete')
Expected: visible
Received: hidden
Call log:
- expect.toBeVisible with timeout 5000ms
- waiting for getByRole('toolbar').getByText('Delete')
53 | expect(toolbar.getByText('Rename')).toBeHidden();
54 | expect(toolbar.getByText('Open')).toBeHidden();
> 55 | expect(toolbar.getByText('Delete')).toBeVisible();
| ^
56 | });
57 |
58 | test('Select files and open', async ({ page, tmpPath }) => {
at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:55:41
|
Test
Process completed with exit code 1.
|
Update snapshots
2 flaky
[firefox] › test/filebrowser.spec.ts:20:7 › File Browser › Select one folder ───────────────────
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
33 passed (1.9m)
|
Test
1 failed
[firefox] › test/menus.spec.ts:37:9 › Notebook Menus › Open menu item View ─────────────────────
2 flaky
[firefox] › test/filebrowser.spec.ts:31:7 › File Browser › Select one file ─────────────────────
[firefox] › test/filebrowser.spec.ts:43:7 › File Browser › Select files and folders ────────────
32 passed (2.2m)
|
Loading