-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct clusterrole permissions for post install job #4016
fix: correct clusterrole permissions for post install job #4016
Conversation
Signed-off-by: Calum Murray <[email protected]>
/cc @pierDipi |
/cherry-pick release-1.14 |
@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.15 |
Test in #4015 |
@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #4016 +/- ##
=============================================
Coverage 48.25% 48.25%
=============================================
Files 246 246
Lines 14540 14540
=============================================
Hits 7016 7016
Misses 6817 6817
Partials 707 707 ☔ View full report in Codecov by Sentry. |
/retest |
/retest-required |
@pierDipi I switched the base branch to 1.15, since I realized the downgrade tests will no longer work for 1.14 -> 1.15 (as there are no deployments to remove anymore) |
/retest-required |
@Cali0707: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
150dddd
into
knative-extensions:release-1.15
@Cali0707: new pull request created: #4022 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Cali0707: base branch (release-1.15) needs to differ from target branch (release-1.15) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
Signed-off-by: Calum Murray <[email protected]>
…ons#4016) (#1158) * fix: correct clusterrole permissions (knative-extensions#4016) Signed-off-by: Calum Murray <[email protected]> * Run make generate-release Signed-off-by: Pierangelo Di Pilato <[email protected]> --------- Signed-off-by: Calum Murray <[email protected]> Signed-off-by: Pierangelo Di Pilato <[email protected]> Co-authored-by: Pierangelo Di Pilato <[email protected]>
Fixes #4000
Proposed Changes