Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for ver2.5. @mhubii I'm not sure how you want to handle this? Currently this overwrites the v1.15. So the PR is not ready to merge. Probably good to add a switch in the build somewhere so the user can specify which version they use.
I would suggest creating a macro that specifies the FRI version, then use something like
Also, I am getting the error when building:
I think the issue is that I made the FRI package non-ament_cmake, so linking the library is not the same. Perhaps this is something you know better than me how to fix?
If you could let me know if you have any ideas re this issue above then I'll fix, and can do the macro support switch thing i mention above. However, for this I will also need to know how you want to handle the switch? Ie. where you think it should be placed?