-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWX-35477 : Support Openshift Prometheus for portworx monitoring on OCP 4.14 #1410
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1410 +/- ##
==========================================
- Coverage 75.88% 75.87% -0.01%
==========================================
Files 66 66
Lines 18840 18965 +125
==========================================
+ Hits 14296 14390 +94
- Misses 3529 3549 +20
- Partials 1015 1026 +11 ☔ View full report in Codecov by Sentry. |
@piyush-nimbalkar -- would you mind reviewing this? It is a fairly complicated PR, and you were the author of the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after addressing the comments.
@nikita-bhatia can we add more UTs for all corner cases like if we don't find the ocp secret or if the right data is not present in it? What happens when we disable and enable autopilot again - it should have the same deployment and the secret should have been deleted when autopilot was disabled.
Let's merge this PR after addressing comments and then add just the UTs in a different PR.
52107c9
to
aac2e47
Compare
Signed-off-by: Piyush Nimbalkar <[email protected]>
Issue : OCP upgrade from 4.13.x to 4.14.5 is blocked due to PX prometheus. From OCP 4.14, PX Prometheus stopped working.
Resolution : From OCP 4.14, Portworx deployment on OCP should should use Openshift prometheus stack for monitoring Portworx metrics instead of deploying PX-Prometheus. We need to expose Portworx metrics to Openshift.
To do this, user-workload-monitoring has to be enabled on OCP cluster to use openshift's monitoring and alerting for portworx.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes # https://portworx.atlassian.net/browse/PWX-35477
Testing done