Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some translations of the broadcast #16254

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Conversation

SergioGlorias
Copy link
Contributor

No description provided.

@SergioGlorias SergioGlorias marked this pull request as draft October 20, 2024 22:20
'Boards can be loaded with a source or via the ',
h('a', { attrs: { href: '/broadcast/app' } }, 'Broadcaster App'),
i18n.broadcast.boardsCanLoaded,
h('a', { attrs: { href: '/broadcast/app' } }, ' Broadcaster App'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i see you're just talking about the space thing. I believe whitespace has always been trimmed from translations, so you may have needed that space regardless.

is used by the arena and I see that it is a variable that can be used more in other places
@SergioGlorias SergioGlorias marked this pull request as ready for review October 21, 2024 17:23
@SergioGlorias SergioGlorias requested a review from schlawg October 21, 2024 17:23
@ornicar ornicar merged commit 9f0c8c6 into lichess-org:master Oct 22, 2024
5 checks passed
Copy link
Collaborator

@superuser-does superuser-does left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With respect to bd49f66:

Is there a reason for the 'streaming API' key being removed please, and would you be open to restoring it @ornicar ?
It now leaves a string in English, within a translatable string.

As an alternative, we could simply instruct translators not to touch 'streaming API' unless they're very confident that their take is better.

@ornicar
Copy link
Collaborator

ornicar commented Nov 17, 2024

With respect to bd49f66:

Is there a reason for the 'streaming API' key being removed please, and would you be open to restoring it @ornicar ? It now leaves a string in English, within a translatable string.

As an alternative, we could simply instruct translators not to touch 'streaming API' unless they're very confident that their take is better.

I removed it because it points to a developer documentation page that is written in english and will not be translated. The term "streaming" here is very likely to be misunderstood by non-developers, and translated wrongly. It's not about video streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants