CV2-5086 Move Smooch NLU to presto #1996
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caiosba not sure why this last error is happening so may want to discuss but otherwise ready for review! I'm going to hold in draft until later though so we can not have a flood of these at the same time. |
OK! This failure seems to be related to the changes at least. |
Allow lists (core, custom, search results, articles, filtered or not) to be exported to a CSV file that is sent to e-mail.
- [x] Add an `exportList` GraphQL mutation
- [x] Implement a generic export class that supports media, articles and feeds
- [x] Validate maximum number of results (which is a global configuration key)
- [x] Validate permission
- [x] Create Sidekiq job to export results
- [x] Create a CSV for the export
- [x] Save CSV in S3 using a pre-signed URL that expires after X days ("X" is a global configuration key)
- [x] Add support to MailCatcher
- [x] Send CSV by e-mail
- [x] Automated tests
- [x] Make sure it works for articles as well
- [x] Make sure it works for shared feeds as well
References: CV2-5067 and CV2-4979.
DGaffney
changed the base branch from
develop
to
epic/cv2-5050-text-vectorization-via-presto
…086-smooch-nlu-presto
caiosba
requested changes
Aug 27, 2024
app/lib/smooch_nlu.rb
Outdated
Comment on lines
47
to
54
| alegre_operation = 'post' | ||
| alegre_params = common_alegre_params.merge({ text: keyword, models: ALEGRE_MODELS_AND_THRESHOLDS.keys }) | ||
| Bot::Alegre.get_sync_raw_params(alegre_params, "text") if alegre_operation && alegre_params | ||
| elsif operation == 'remove' | ||
| keywords -= [keyword] | ||
| alegre_operation = 'delete' | ||
| alegre_params = common_alegre_params.merge({ quiet: true }) | ||
| Bot::Alegre.request_delete_from_raw(alegre_params, "text") if alegre_operation && alegre_params |
There was a problem hiding this comment.
This can be simplified further, it seems... you don't need alegre_operation anymore, since the calls were moved to the condition blocks... right?
There was a problem hiding this comment.
you're right! Updated.
Co-authored-by: chinelo-obitube <[email protected]>
…ch. (#2004) Fixes CV2-5127.
Allow lists (core, custom, search results, articles, filtered or not) to be exported to a CSV file that is sent to e-mail.
- [x] Add an `exportList` GraphQL mutation
- [x] Implement a generic export class that supports media, articles and feeds
- [x] Validate maximum number of results (which is a global configuration key)
- [x] Validate permission
- [x] Create Sidekiq job to export results
- [x] Create a CSV for the export
- [x] Save CSV in S3 using a pre-signed URL that expires after X days ("X" is a global configuration key)
- [x] Add support to MailCatcher
- [x] Send CSV by e-mail
- [x] Automated tests
- [x] Make sure it works for articles as well
- [x] Make sure it works for shared feeds as well
References: CV2-5067 and CV2-4979.
Co-authored-by: chinelo-obitube <[email protected]>
…ch. (#2004) Fixes CV2-5127.
Co-authored-by: chinelo-obitube <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More work to move some of the lower level Alegre uses over to presto.
References: CV2-5086
How has this been tested?
Not yet tested - changing code first to determine effect of changes then work through necessary changes from there - testing will need to just ensure that articles do in fact get indexed if you send these commands to alegre from check-api
Things to pay attention to during code review
Nothing in particular
Checklist