Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decontamination workflow #72

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

decontamination workflow #72

wants to merge 4 commits into from

Conversation

LaurenHuet
Copy link

added sub workflow for decontamination pipeline, write 2 local modules, (these still contain some // comments for NF-CORE to do. Could possibly make one of these into an actual NF-core module.

Fixed issues with the decompression of gzipped files

@LaurenHuet
Copy link
Author

Actions:
need to update sample sheet to include taxon id (NCBI taxon ID for fcs to run properly) this then needs to be updated in the workflow, currently just being passed into the process as a value.
Need documentation for how to install NCBI db locally which can be passed onto the command line

@FernandoDuarteF
Copy link
Collaborator

Hi @LaurenHuet, are you going to continue with this PR?

If not, is it OK if I carry on from here? Using your fork.

@LaurenHuet
Copy link
Author

Hi Fernando,
I had stopped working on it as @mahesh-panchal was making some changes to the fcsgx modules, I'm not certain if all the updates he wanted to make are complete as of yet?

@mahesh-panchal
Copy link
Member

I've been a bit busy. There's still the fcs adapter modules to update, but to be honest, don't let my non-progress stop you. Incorporate what's been done already and complete the PR. You can always make a new PR later to update the modules once they're updated on nf-core.

@FernandoDuarteF
Copy link
Collaborator

Hi @LaurenHuet.

I think merging this should be straight forward except for the conflicts that have to be resolved. The pipeleline has changed a bit in the last few weeks, you might have some problems resolving conflicts. Is it okay if I do it for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants