Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added orientation descriptor in RigidTransformation and SimilarityTransformation compute functions. #553

Merged
merged 8 commits into from
Feb 28, 2024

Conversation

simonpierredeschenes
Copy link
Collaborator

Description

Summary:

Applied rotations to orientation descriptors in TransfomationImpl.cpp. These descriptors come from norlab_icp_mapper.

Changes and type of changes (quick overview):

  • feature: Applied rotations to orientation descriptors in TransfomationImpl.cpp

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check README.md #Contributing
    for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding type
    • Types: feat fix docs style refactor perf test build ci chore revert
    • Breaking changes: <type>!
    • Reference:
      see commit_msg_reference.md
      in the repository root for details

Note for repository admins

Release PR related

  • Only repository admins have the privilege to push/merge on the default branch (ie: master)
    and the release branch.
  • Keep PR in draft mode until all the release reviewers are ready to push the release.
  • Once a PR from release -> master branch is created (not in draft mode),
    • it triggers the build-system test
    • (in-progress) and it triggers the semantic release automation

pointmatcher/TransformationsImpl.cpp Outdated Show resolved Hide resolved
aguenette
aguenette previously approved these changes Jan 25, 2024
boxanm
boxanm previously approved these changes Feb 9, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@boxanm boxanm merged commit 3af6129 into develop Feb 28, 2024
5 of 6 checks passed
@boxanm boxanm deleted the orientation_descriptor branch February 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants