-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string escaping #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests to verify you can add to the PR? |
You can create a new metadata store pointing to a Postgres DB, and then experiment with text you would usually insert for e.g. a description formatted as markdown (which is what motivated this patch). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also notice version bumps in bazel will likely require a different set of "snapshotted dependency cache" for which @rimolive @lampajr are more familiar.
+1 once we will create the release branch we should have to re-generate the external dependencies/cache archive
The change lgtm but I'd like to test it together with #1 in order to be sure that the build would work on ubi/fedora images
* Fix MLMD build on Fedora Signed-off-by: Andrea Lamparelli <[email protected]> * Revert zetasql upgrade and switch to ubi8 (#2) --------- Signed-off-by: Andrea Lamparelli <[email protected]>
I'd hold this PR a little bit because I'd like to setup a simple CI that performs a container build of the |
e46c11d
to
e12ca60
Compare
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Isabella Basso do Amaral <[email protected]>
e12ca60
to
d9bbab0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I did not test the changes, but as there's no test instructions and according to Andrea's comment, you will provide an automated way to test PRs.
Description
I started by adding a gitignore as a basic chore to help me debug this, as well.
Fixed a string escape bug that was preventing us from adding certain values on the table using PSQL.
The behavior should remain unaltered for other DB backends.
I've also bumped the PSQL-12 client version.
How Has This Been Tested?
Tested with the Python MLMD client.
Merge criteria: