chore(Cross): [IOAPPX-434] Update the main icon app for iOS + Add support for dark and tinted appearances #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6415 +/- ##
==========================================
- Coverage 48.42% 47.69% -0.74%
==========================================
Files 1488 1604 +116
Lines 31617 32216 +599
Branches 7669 7441 -228
==========================================
+ Hits 15311 15365 +54
- Misses 16238 16798 +560
+ Partials 68 53 -15 see 1657 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hantex9
approved these changes
Nov 20, 2024
dmnplb
added a commit
that referenced
this pull request
Nov 25, 2024
…a channel and fix App Store issue (#6451) ## Short description This PR updates the `IconApp` iOS assets, introduced in the PR #6415, to fix the App Store Connect issue. The previous assets incorrectly included an alpha channel even when there was no transparent layer, as you can see in the attached screenshot: <img width="384" alt="Screenshot 2024-11-25 at 12 11 48" src="https://github.com/user-attachments/assets/6c95d8aa-7ac3-45a9-8b37-0b25cfd5264b"> ## List of changes proposed in this pull request - Remove alpha channel from the PNG related to the light and tinted appearances - Leave alpha channel on the dark appearance only - Assign the `sRGB` color profile to all the icons ## How to test Try to build the app with App Store Connect and pray 🙏 Co-authored-by: Cristiano Tofani <[email protected]>
dmnplb
added a commit
that referenced
this pull request
Nov 26, 2024
…ection (#6458) ## Short description This PR removes dark mode app icon to try to fix build rejection. ### Related PRs * #6415 * #6451 ## How to test N/A Co-authored-by: Cristiano Tofani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR updates the main icon app for iOS and adds support for dark and tinted appearances. Check out the video below for a preview.
List of changes proposed in this pull request
1024×1024size for default, dark and tinted appearancesPreview
dynamic-app-icons.mp4
How to test