Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update PD client to fix the backoffer retry #53718

Merged
merged 1 commit into from
May 31, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented May 31, 2024

What problem does this PR solve?

Issue Number: close #53719, close tikv/pd#8142.

Problem Summary:

What changed and how does it work?

Update PD client to fix the backoffer retry by adopting tikv/pd#8227.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Update PD client to fix the bug where HTTP client retry logic is ineffective.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels May 31, 2024
@JmPotato
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 31, 2024
Copy link

ti-chi-bot bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 31, 2024
Copy link

ti-chi-bot bot commented May 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 09:23:14.708631491 +0000 UTC m=+3027548.465767059: ☑️ agreed by hi-rustin.
  • 2024-05-31 09:27:10.832749343 +0000 UTC m=+3027784.589884917: ☑️ agreed by nolouch.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8660%. Comparing base (35e09a2) to head (f302701).

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53718        +/-   ##
================================================
+ Coverage   72.5200%   73.8660%   +1.3460%     
================================================
  Files          1506       1506                
  Lines        430950     430988        +38     
================================================
+ Hits         312525     318354      +5829     
+ Misses        99061      93088      -5973     
- Partials      19364      19546       +182     
Flag Coverage Δ
integration 47.2399% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 42.1666% <ø> (+0.3501%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit fa66bba into pingcap:master May 31, 2024
23 checks passed
@JmPotato JmPotato deleted the update_pd_client branch May 31, 2024 10:06
@JmPotato
Copy link
Member Author

/cherry-pick release-8.1

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request May 31, 2024
@ti-chi-bot
Copy link
Member

@JmPotato: new pull request created to branch release-8.1: #53722.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants