Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update PD client to fix the backoffer retry (#53718) #53722

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53718

What problem does this PR solve?

Issue Number: close #53719, close tikv/pd#8142.

Problem Summary:

What changed and how does it work?

Update PD client to fix the backoffer retry by adopting tikv/pd#8227.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Update PD client to fix the bug where HTTP client retry logic is ineffective.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 31, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 31, 2024
Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 31, 2024
Copy link

ti-chi-bot bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hi-rustin, JmPotato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 31, 2024
Copy link

ti-chi-bot bot commented May 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 10:22:16.818256961 +0000 UTC m=+3031090.575392534: ☑️ agreed by JmPotato.
  • 2024-05-31 10:26:28.454726454 +0000 UTC m=+3031342.211862183: ☑️ agreed by hi-rustin.

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@b8a2b9e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #53722   +/-   ##
================================================
  Coverage               ?   71.1711%           
================================================
  Files                  ?       1465           
  Lines                  ?     421470           
  Branches               ?          0           
================================================
  Hits                   ?     299965           
  Misses                 ?     101027           
  Partials               ?      20478           
Flag Coverage Δ
unit 71.1711% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 40.9267% <0.0000%> (?)

@JmPotato
Copy link
Member

/test build

Copy link

tiprow bot commented May 31, 2024

@JmPotato: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 0416305 into pingcap:release-8.1 May 31, 2024
18 checks passed
@JmPotato JmPotato deleted the cherry-pick-53718-to-release-8.1 branch May 31, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants