Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix_power to quantum_info.linalg_operations #1454

Merged
merged 30 commits into from
Sep 20, 2024
Merged

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Sep 18, 2024

Needs qiboteam/qibojit#189

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Sep 18, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Sep 18, 2024
@renatomello renatomello self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (ee6286c) to head (41bc698).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1454   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          81       81           
  Lines       11734    11740    +6     
=======================================
+ Hits        11727    11733    +6     
  Misses          7        7           
Flag Coverage Δ
unittests 99.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/qibo/backends/numpy.py Show resolved Hide resolved
src/qibo/backends/pytorch.py Show resolved Hide resolved
src/qibo/quantum_info/linalg_operations.py Outdated Show resolved Hide resolved
@renatomello
Copy link
Contributor Author

@scarrazza this is ready on my side and the corresponding qibojit PR was already merged. Tests and coverage are passing.

@MatteoRobbiati MatteoRobbiati self-requested a review September 20, 2024 08:49
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Everything looks good, I just leave some comments below.

doc/source/api-reference/qibo.rst Show resolved Hide resolved
src/qibo/backends/numpy.py Show resolved Hide resolved
src/qibo/backends/abstract.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/linalg_operations.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renatomello renatomello added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 22d5194 Sep 20, 2024
25 checks passed
@renatomello renatomello deleted the matrix_power branch September 20, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants