Export of the get_cm_node_options() from robostack when compiling for Windows. #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
jackcenter,
mcbed,
mhubii and
qiayuanl
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1129 +/- ##
=======================================
Coverage 31.57% 31.57%
=======================================
Files 94 94
Lines 10736 10736
Branches 7347 7347
=======================================
Hits 3390 3390
Misses 804 804
Partials 6542 6542
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2023
(cherry picked from commit e077360)
|
Thanks ! |
bmagyar
pushed a commit
that referenced
this pull request
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly to apply upstream a patch from robostack to have the code compiling on Windows on user request:
https://github.com/RoboStack/ros-humble/blob/main/patch/ros-humble-controller-manager.patch
I believe that the modification is minimal and has zero impact on the code itself.
Tested with colcon test on rolling. If possible it would be nice to have it backported on humble.