Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the launch_utils regression #1909

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

saikishor
Copy link
Member

Fix the recently introduced launch_utils regression

def generate_controllers_spawner_launch_description(
controller_names: list, controller_params_files=None, extra_spawner_args=[]
):

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (89fd4ef) to head (bf74701).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
- Coverage   87.59%   87.56%   -0.03%     
==========================================
  Files         122      122              
  Lines       12766    12767       +1     
  Branches     1146     1146              
==========================================
- Hits        11182    11180       -2     
- Misses       1155     1157       +2     
- Partials      429      430       +1     
Flag Coverage Δ
unittests 87.56% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...troller_manager/controller_manager/launch_utils.py 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 3, 2024
@bmagyar bmagyar merged commit 3052b58 into ros-controls:master Dec 4, 2024
14 of 20 checks passed
mergify bot pushed a commit that referenced this pull request Dec 4, 2024
(cherry picked from commit 3052b58)

# Conflicts:
#	controller_manager/controller_manager/launch_utils.py
@saikishor saikishor deleted the fix/launch_utils branch December 4, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants