-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jazzy release 0.26.6 #1885
Jazzy release 0.26.6 #1885
Conversation
Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
6feed24
to
5103284
Compare
Fixed DCO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoag Could you please clean up the list of commit messages to concisely convey the notable changes that have been made to the packages since the last release?
We usually keep only PR's title and who was the contributors and authors.
for Instance
* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
* publish clock after the delay is over
* Disable delay period in subsequent loops (ros2 bag play)
* Reset clock publisher timer outisde playback loop
* review
---------
(cherry picked from commit 15b82607d0e36a6ff87f60405b072919d16fb03d)
Co-authored-by: Nicola Loi <[email protected]>
would be
* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
Co-authored-by: Nicola Loi <[email protected]>
Signed-off-by: Marco A. Gutierrez <[email protected]>
True, forgot this, I'll trim all that extra stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, but I'd like another review from @MichaelOrlov before we merge.
Off-topic, but, when squash-merging (rebasing) using the GitHub API, I think we should always delete the description that GitHub creates from the individual commit titles/descriptions. It's just not useful (certainly not stuff like "review"), and it's always in the PR anyway. It should ideally be replaced by the PR description. For example, 15b8260 should simply be:
with optionally the PR description (updated once the PR is in its final state, before merging) before the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoag Thank you for releasing Rosbag2.
Now PR looks good to me. Approved!
@marcoag Please don't forget to create a correct |
Once this is approved, I'll squash merge it onto the jazzy branch, add the
0.26.6
tag, and bloom-release it.