Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy release 0.26.6 #1885

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Jazzy release 0.26.6 #1885

merged 3 commits into from
Dec 20, 2024

Conversation

marcoag
Copy link
Contributor

@marcoag marcoag commented Dec 18, 2024

Once this is approved, I'll squash merge it onto the jazzy branch, add the 0.26.6 tag, and bloom-release it.

Signed-off-by: Marco A. Gutierrez <[email protected]>
@marcoag marcoag requested a review from a team as a code owner December 18, 2024 03:36
@marcoag marcoag requested review from james-rms and jhdcs and removed request for a team December 18, 2024 03:36
Signed-off-by: Marco A. Gutierrez <[email protected]>
@marcoag marcoag force-pushed the marcoag/jazzy-0.26.6 branch from 6feed24 to 5103284 Compare December 18, 2024 03:37
@marcoag
Copy link
Contributor Author

marcoag commented Dec 18, 2024

Fixed DCO.

@marcoag marcoag requested a review from MichaelOrlov December 18, 2024 03:38
liblz4_vendor/CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoag Could you please clean up the list of commit messages to concisely convey the notable changes that have been made to the packages since the last release?
We usually keep only PR's title and who was the contributors and authors.
for Instance

* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
  * publish clock after the delay is over
  * Disable delay period in subsequent loops (ros2 bag play)
  * Reset clock publisher timer outisde playback loop
  * review
  ---------
  (cherry picked from commit 15b82607d0e36a6ff87f60405b072919d16fb03d)
  Co-authored-by: Nicola Loi <[email protected]>

would be

* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
 Co-authored-by: Nicola Loi <[email protected]>

Signed-off-by: Marco A. Gutierrez <[email protected]>
@marcoag
Copy link
Contributor Author

marcoag commented Dec 19, 2024

@marcoag Could you please clean up the list of commit messages to concisely convey the notable changes that have been made to the packages since the last release? We usually keep only PR's title and who was the contributors and authors. for Instance

* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
  * publish clock after the delay is over
  * Disable delay period in subsequent loops (ros2 bag play)
  * Reset clock publisher timer outisde playback loop
  * review
  ---------
  (cherry picked from commit 15b82607d0e36a6ff87f60405b072919d16fb03d)
  Co-authored-by: Nicola Loi <[email protected]>

would be

* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
 Co-authored-by: Nicola Loi <[email protected]>

True, forgot this, I'll trim all that extra stuff.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, but I'd like another review from @MichaelOrlov before we merge.

@christophebedard
Copy link
Member

christophebedard commented Dec 19, 2024

* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
  * publish clock after the delay is over
  * Disable delay period in subsequent loops (ros2 bag play)
  * Reset clock publisher timer outisde playback loop
  * review
  ---------
  (cherry picked from commit 15b82607d0e36a6ff87f60405b072919d16fb03d)
  Co-authored-by: Nicola Loi <[email protected]>

would be

* Publish clock after delay is over and disable delay on next loops (`#1861 <https://github.com/ros2/rosbag2/issues/1861>`_) (`#1878 <https://github.com/ros2/rosbag2/issues/1878>`_)
 Co-authored-by: Nicola Loi <[email protected]>

Off-topic, but, when squash-merging (rebasing) using the GitHub API, I think we should always delete the description that GitHub creates from the individual commit titles/descriptions. It's just not useful (certainly not stuff like "review"), and it's always in the PR anyway. It should ideally be replaced by the PR description.

For example, 15b8260 should simply be:

Publish clock after delay is over and disable delay on next loops (#1861)

Signed-off-by: ...

with optionally the PR description (updated once the PR is in its final state, before merging) before the Signed-off-by: line.

Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcoag Thank you for releasing Rosbag2.
Now PR looks good to me. Approved!

@MichaelOrlov
Copy link
Contributor

@marcoag Please don't forget to create a correct 0.26.6 tag after Squash and merge operation for this PR

@marcoag marcoag merged commit 02f7b89 into jazzy Dec 20, 2024
12 checks passed
@marcoag marcoag deleted the marcoag/jazzy-0.26.6 branch December 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants