Auto detection fix for Kontronik ESCs - verified Kolibri v3.0/v3.5, Kosmik 200 HV v4.17, JivePro 120 HV v1.13 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v3.5, Kosmik 200 HV v4.17, JivePro 120 HV v1.13
rotorflight
requested changes
Apr 20, 2024
src/main/sensors/esc_sensor.c
Outdated
| } | ||
| else if (kontronikPacketLength == 0 && readBytes == KON_FRAME_LENGTH) { | ||
| // auto detect 40 byte packet... | ||
| uint32_t crc = kontronikDecodeCRC(40 - KON_CRC_LENGTH); |
There was a problem hiding this comment.
Other frame sizes are #defines, 40 is not. Please fix.
There was a problem hiding this comment.
Ops - done.
Code path verified w/ Kolibri v3.5.
…erified w/ Kolibri v3.5
rotorflight
approved these changes
Apr 25, 2024
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Apr 27, 2024
* master: Fix for CMS feature disabled issue on Spektrum telemetry (rotorflight#106) Update CMS flight profile menus (rotorflight#104) Auto detection fix for Kontronik ESCs (rotorflight#100)
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
May 4, 2024
* Auto detection fix for legacy Kontronik ESCs - verified Kolibri v3.0/v3.5, Kosmik 200 HV v4.17, JivePro 120 HV v1.13 * Auto detection fix for legacy Kontronik ESCs - minor code cleanup - verified w/ Kolibri v3.5
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
May 10, 2024
* Auto detection fix for legacy Kontronik ESCs - verified Kolibri v3.0/v3.5, Kosmik 200 HV v4.17, JivePro 120 HV v1.13 * Auto detection fix for legacy Kontronik ESCs - minor code cleanup - verified w/ Kolibri v3.5
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
May 10, 2024
* esc_sensor_hd_rc3: Auto detection fix for Kontronik ESCs (rotorflight#100) hd - IQ22 - improper use of round(...) w/ float type, replace with roundf(...) - unit and device tests ok for range of values used hd - IQ22 - use float vs double - tests ok for range of values used hd - void signature fixes, kon status as 32 bit ESC Setup - pre-pr code cosmetics, more defined constants, removed deprecated unc Release Candidate 4.3.0-RC3 Fix Governor Passthrough IDLE state throttle tracking hd - pl5 - added OOB restart + identification, cleanup ESC Setup - param - OOB status (restart needed) and device identification Use servo pulse limits for output throttle Change gov_max_throttle range to 0..100% Fix hover drift in PID mode 3 Fix for CMS feature disabled issue on Spektrum telemetry (rotorflight#106) hd - pl5 - added writeparams req, resp, err hd - pl5 - enter MSP editor from tele hd - pl5 - added: device info & get params req, extended decoder for additional responses, pack param payload for MSP editor hd - pl5 - hw5 / pl5 ported to rrfsm ESC Setup - scorpion - remove enc telemetry data ESC Setup - scorpion - unc timeout fixes, minor cosmetics Release Candidate 4.3.0-RC2
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
May 13, 2024
* Auto detection fix for legacy Kontronik ESCs - verified Kolibri v3.0/v3.5, Kosmik 200 HV v4.17, JivePro 120 HV v1.13 * Auto detection fix for legacy Kontronik ESCs - minor code cleanup - verified w/ Kolibri v3.5
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
May 13, 2024
* master: Add ESC Forward programming for YGE and Scorpion ESCs (rotorflight#108) Improve yaw precomp filtering Fix Governor Passthrough IDLE state throttle tracking Use servo pulse limits for output throttle Change gov_max_throttle range to 0..100% Fix CMS label alignment on small screen (rotorflight#109) Add CMS Rescue, PID controller and bandwidth menus (rotorflight#107) Fix hover drift in PID mode 3 Fix for CMS feature disabled issue on Spektrum telemetry (rotorflight#106) Update CMS flight profile menus (rotorflight#104) Auto detection fix for Kontronik ESCs (rotorflight#100) # Conflicts: # src/main/sensors/esc_sensor.c
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Jun 5, 2024
* Auto detection fix for legacy Kontronik ESCs - verified Kolibri v3.0/v3.5, Kosmik 200 HV v4.17, JivePro 120 HV v1.13 * Auto detection fix for legacy Kontronik ESCs - minor code cleanup - verified w/ Kolibri v3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #99 (branch cleanup, single commit cherry picked)
Enhancement to #98 to handle legacy and current Kontronik ESCs
assume length unknown
while length unknown
test at 38 bytes for valid CRC for 32 or 34 byte payload, set expected length == 38 (and crc exclusion) if yes
test at 40 bytes for valid CRC, set expected length = 40 if yes, if no as usual
when length known
use length determined for all subsequent packets