Fix for current FW Kontronik ESCs - verified Kolibri v3.0/v3.5, Kosmik 200 HV v4.17 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotorflight
requested changes
Apr 14, 2024
|
Protocol documentation updated. |
|
Suggest reviewing #99 instead. |
rotorflight
approved these changes
Apr 15, 2024
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Apr 15, 2024
* master: Fix Kontronik telemetry protocol (rotorflight#98) Update README.md Add Horizon mode inverted self-leveling Add CI or PR to the firmware extra version string OpenYGE - fix: address possible buffer underflow condition, add 2nd paranoid frame length validation outside ISR/callback (rotorflight#96) Fix RPM filter error check with Direct Drive motors (rotorflight#94) Fix TTA headroom calculation in Gov Passthrough (rotorflight#92) Add GOV_MODE FrSky telemetry sensor (rotorflight#89) Add github workflows for CI builds OpenYGE - fix to support v3 frame header extension (rotorflight#87) chore: fixed scale lights terminology (rotorflight#85) Add Releases.md Update github workflows Reduce default smoothing level Simplify RC frame rate calculation Change default PID D-gains Change default motor protocol to PWM Add 'mixer reset' to mixer CLI help # Conflicts: # src/main/sensors/esc_sensor.c
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Apr 15, 2024
* esc_sensor_data_plus: (21 commits) RFF-78 - escSensorData - added .throttle to. capture input setpoint as reported by ESC Fix Kontronik telemetry protocol (rotorflight#98) Update README.md Add Horizon mode inverted self-leveling Add CI or PR to the firmware extra version string OpenYGE - fix: address possible buffer underflow condition, add 2nd paranoid frame length validation outside ISR/callback (rotorflight#96) Fix RPM filter error check with Direct Drive motors (rotorflight#94) Fix TTA headroom calculation in Gov Passthrough (rotorflight#92) Add GOV_MODE FrSky telemetry sensor (rotorflight#89) Add github workflows for CI builds OpenYGE - telemetry - BEC voltage and current fix OpenYGE - fix to support v3 frame header extension (rotorflight#87) OpenYGE - support v3 frame header extension - documentation chore: fixed scale lights terminology (rotorflight#85) Add Releases.md Update github workflows Reduce default smoothing level Simplify RC frame rate calculation Change default PID D-gains Change default motor protocol to PWM ... # Conflicts: # src/main/sensors/esc_sensor.c
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Apr 15, 2024
* esc_sensor_data_plus: (21 commits) RFF-78 - escSensorData - added .throttle to. capture input setpoint as reported by ESC Fix Kontronik telemetry protocol (rotorflight#98) Update README.md Add Horizon mode inverted self-leveling Add CI or PR to the firmware extra version string OpenYGE - fix: address possible buffer underflow condition, add 2nd paranoid frame length validation outside ISR/callback (rotorflight#96) Fix RPM filter error check with Direct Drive motors (rotorflight#94) Fix TTA headroom calculation in Gov Passthrough (rotorflight#92) Add GOV_MODE FrSky telemetry sensor (rotorflight#89) Add github workflows for CI builds OpenYGE - telemetry - BEC voltage and current fix OpenYGE - fix to support v3 frame header extension (rotorflight#87) OpenYGE - support v3 frame header extension - documentation chore: fixed scale lights terminology (rotorflight#85) Add Releases.md Update github workflows Reduce default smoothing level Simplify RC frame rate calculation Change default PID D-gains Change default motor protocol to PWM ... # Conflicts: # src/main/sensors/esc_sensor.c
bob01
added a commit
to bob01/rotorflight-firmware
that referenced
this pull request
Apr 15, 2024
* esc_sensor_hd: (24 commits) CRSF - reuse - minor code consistency - missing comma CRSF - reuse - expose additional ESC sources on ATT 16-bit sensors - not enough room on GPS sensors REUSE - added BEC, BUS, MPU voltage sources to GPS sensor options RFF-78 - escSensorData - added .throttle to. capture input setpoint as reported by ESC Fix Kontronik telemetry protocol (rotorflight#98) Update README.md Add Horizon mode inverted self-leveling Add CI or PR to the firmware extra version string OpenYGE - fix: address possible buffer underflow condition, add 2nd paranoid frame length validation outside ISR/callback (rotorflight#96) Fix RPM filter error check with Direct Drive motors (rotorflight#94) Fix TTA headroom calculation in Gov Passthrough (rotorflight#92) Add GOV_MODE FrSky telemetry sensor (rotorflight#89) Add github workflows for CI builds OpenYGE - telemetry - BEC voltage and current fix OpenYGE - fix to support v3 frame header extension (rotorflight#87) OpenYGE - support v3 frame header extension - documentation chore: fixed scale lights terminology (rotorflight#85) Add Releases.md Update github workflows Reduce default smoothing level ... # Conflicts: # src/main/cli/settings.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current ESC FW for the Jive (v1.17) / Kolibri (3.0 - 3.5) / Kosmik (v4.17) are 40 byte data + 44 byte info.
JivePro/Kosmic v*.13 were different 38 byte w/ 32 byte payload, 2 extra bytes and 4 byte CRC, based on release notes it is likely that the *.14 versions switched to the current 40 byte packet but this could not be verified due to lack of test subjects.
This is a simple fix to support modern 40 byte packet - a more elaborate scheme to support older controllers is outside of RF RC scope, possible future consideration.
Kosmik 250 HV-I could not be properly verified due to what appears to be an unrelated defect - versions 1.17 - 1.25 appeared to produce correct 40 byte but broken frames.