refactor(mempool_test_utils): add non mut account_with_id, rename previous implementation

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• test(starknet_integration_tests): test deploy account txs in flow test #2807
• feat(mempool_test_utils,starknet_integration_tests): prepare funded but undeployed accounts #2986
• test(starknet_integration_tests): fund contract address for deployment #2806
• feat(mempool_test_utils): util to generate deploy account txs #2805
• feat(mempool_test_utils): utility to create transfer txs #2804
• fix(mempool_test_utils): remove unnecessary pub #2803
• feat(mempool_test_utils): register accounts as deployed or undeployed #2802
• refactor(mempool_test_utils): add non mut account_with_id, rename previous implementation #2801 👈 (View in Graphite)
• feat(starknet_integration_tests): pass test scenarios from the test body #2724
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (12/19/24)

1 assignee was added to this PR based on Yair's automation.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-26T13:10:51Z

[alonh5]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

---

crates/mempool_test_utils/src/starknet_api_test_utils.rs line 209 at r1 (raw file):

    }

    pub fn account_with_id(&self, account_id: AccountId) -> &AccountTransactionGenerator {

Why do you need both?

[yair-starkware]

crates/mempool_test_utils/src/starknet_api_test_utils.rs line 209 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Why do you need both?

We need to hold the funding account and the account to be deployed simultaneously. It is not possible if they require a mutable ref of self

[alonh5]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

---

crates/mempool_test_utils/src/starknet_api_test_utils.rs line 209 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

We need to hold the funding account and the account to be deployed simultaneously. It is not possible if they require a mutable ref of self

Got it, thanks!