feat(mempool_test_utils,starknet_integration_tests): prepare funded but undeployed accounts

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• test(starknet_integration_tests): test deploy account txs in flow test #2807
• feat(mempool_test_utils,starknet_integration_tests): prepare funded but undeployed accounts #2986 👈 (View in Graphite)
• test(starknet_integration_tests): fund contract address for deployment #2806
• feat(mempool_test_utils): util to generate deploy account txs #2805
• feat(mempool_test_utils): utility to create transfer txs #2804
• fix(mempool_test_utils): remove unnecessary pub #2803
• feat(mempool_test_utils): register accounts as deployed or undeployed #2802
• refactor(mempool_test_utils): add non mut account_with_id, rename previous implementation #2801
• feat(starknet_integration_tests): pass test scenarios from the test body #2724
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (12/26/24)

1 assignee was added to this PR based on Yair's automation.

[alonh5]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yair-starkware)

---

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):

    }

    // TODO(deploy_account_support): delete method once we have batcher with execution.

Can we delete this here and deploy accounts only with txs now that you have added support for that?

Code quote:

// TODO(deploy_account_support): delete method once we have batcher with execution.

[yair-starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Can we delete this here and deploy accounts only with txs now that you have added support for that?

Isn't it used by the integration test as well?

[yair-starkware]

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

Isn't it used by the integration test as well?

IMO this whole module shouldn't exist.
Needs to be part of the MultiAccountTxGenerator.

[alonh5]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yair-starkware)

---

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):
Yes you're right it's used in the integration test.

Needs to be part of the MultiAccountTxGenerator
Do you think it's easy and we should do it now?

---

crates/starknet_integration_tests/src/state_reader.rs line 427 at r2 (raw file):

    }

    // TODO(deploy_account_support): delete method once we have batcher with execution.

Here you can remove it right?

Code quote:

// TODO(deploy_account_support): delete method once we have batcher with execution.

[yair-starkware]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Yes you're right it's used in the integration test.

Needs to be part of the MultiAccountTxGenerator
Do you think it's easy and we should do it now?

I don't think it's that easy.
I think we should do it before adding more flows to the e2e tests.

---

crates/starknet_integration_tests/src/state_reader.rs line 427 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Here you can remove it right?

The functions are still needed because we can't update the state with the transfer txs yet.
Also, I think it's a useful functionality for easy setups (instead of needing to fund, declare and deploy every contract in every test).
Removed the TODOs.

[alonh5]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

---

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

I don't think it's that easy.
I think we should do it before adding more flows to the e2e tests.

Okay, can you add a TODO for it then?

---

crates/starknet_integration_tests/src/state_reader.rs line 427 at r2 (raw file):

Previously, yair-starkware (Yair) wrote…

The functions are still needed because we can't update the state with the transfer txs yet.
Also, I think it's a useful functionality for easy setups (instead of needing to fund, declare and deploy every contract in every test).
Removed the TODOs.

Yes I only meant remove the TODO here.

[alonh5]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

[yair-starkware]

Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/starknet_integration_tests/src/state_reader.rs line 412 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Okay, can you add a TODO for it then?

Done

[alonh5]

Reviewed 3 of 4 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)