test(starknet_integration_tests): test deploy account txs in flow test

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• test(starknet_integration_tests): test deploy account txs in flow test #2807 👈 (View in Graphite)
• feat(mempool_test_utils,starknet_integration_tests): prepare funded but undeployed accounts #2986
• test(starknet_integration_tests): fund contract address for deployment #2806
• feat(mempool_test_utils): util to generate deploy account txs #2805
• feat(mempool_test_utils): utility to create transfer txs #2804
• fix(mempool_test_utils): remove unnecessary pub #2803
• feat(mempool_test_utils): register accounts as deployed or undeployed #2802
• refactor(mempool_test_utils): add non mut account_with_id, rename previous implementation #2801
• feat(starknet_integration_tests): pass test scenarios from the test body #2724
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (12/19/24)

1 assignee was added to this PR based on Yair's automation.

[yair-starkware]

Reviewable status: 0 of 5 files reviewed, 7 unresolved discussions (waiting on @alonh5)

---

crates/starknet_integration_tests/src/state_reader.rs line at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Can you explain the changes in this file? Was this one of the bugs you found?

Yes.
If you register multiple contracts with the same class, the class will be declared multiple times, and it will fail.
These changes make classes be declared only once.

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 102 at r2 (raw file):

Can you create a function for this and remove the Boxes? You can get the undeployed account with its ID.

Done

do we need an extra block or can we have the funding and the deployment in the same block?

We need another block, otherwise the GW will reject the deployment tx because there is not enough balance (once we remove the initial balance from the test setup)

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 128 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Remove.

Done.

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 279 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

You should add Code Spell Checker extension to vscode.

Fixed (the code moved)

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 293 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Can you instead use the ID to get the account? Why do we need to check that it's the last?

Technically, nothing is coupling the account IDs in the tests to their index in the generator.
This is another thing we need to refactor in the utility.
What happens if someone registers more accounts in the middle?

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 302 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

If there isn't anything else we want to test, we can just have one function for both.

Done.

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 280 at r2 (raw file):

fn fund_new_account(
    funding_acount: &mut AccountTransactionGenerator,
    to: &Contract,

Same

[alonh5]

Reviewed 3 of 5 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yair-starkware)

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 293 at r2 (raw file):

Previously, yair-starkware (Yair) wrote…

Technically, nothing is coupling the account IDs in the tests to their index in the generator.
This is another thing we need to refactor in the utility.
What happens if someone registers more accounts in the middle?

So it will fail here but it won't be clear why. You should assert the the account id is equal to UNDEPLOYED_ACCOUNT_ID when registering it, and then use UNDEPLOYED_ACCOUNT_ID to get it (as you did in create_funding_txs for example).

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 113 at r5 (raw file):

type ExpectedContentId = Felt;

fn create_test_scenarios() -> Vec<(CreateRpcTxsFn, TestTxHashesFn, ExpectedContentId)> {

Add height also instead of ziping them together?
Also document this function.

Suggestion:

create_test_blocks

[yair-starkware]

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 293 at r2 (raw file):

You should assert the the account id is equal to UNDEPLOYED_ACCOUNT_ID when registering it

Already doing it: https://github.com/starkware-libs/sequencer/blob/93e65241d683e55739d80c20b1f26385ee9bcfdf/crates/starknet_integration_tests/src/utils.rs#L188

and then use UNDEPLOYED_ACCOUNT_ID to get it

Done

[yair-starkware]

Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 113 at r5 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Add height also instead of ziping them together?
Also document this function.

Done.

[alonh5]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)

[alonh5]

Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)