Implement Component for RangeCheckUnitComponent.

[alonh5]

This change is 

[alonh5]

• Test memory trace. #27
• Get range check inputs one by one. #25
• Implement memory component prover. #24
• Write memory interaction trace. #23
• Add memory component. #19
• Evaluate constraints together. #18
• Add lookup step constraint. #17
• Add last lookup boundary constraint. #16
• Implement ComponentProver for RangeCheckUnitComponent. #13
• Implement Component for RangeCheckUnitComponent. #12 👈
• Update stwo and fix changes. #11
• Add rust format file. #14
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite

[shaharsamocha7]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 58 at r1 (raw file):

    fn max_constraint_log_degree_bound(&self) -> u32 {
        self.log_n_instances

The step constraint is of degree 2, right?

Suggestion:

self.log_n_instances + 1?

---

stwo_cairo_prover/src/components/range_check_unit.rs line 94 at r1 (raw file):

            interaction_elements,
            constraint_zero_domain,
        );

Why not adding all the constraints?

Code quote:

        self.evaluate_lookup_boundary_constraints_at_point(
            point,
            mask,
            evaluation_accumulator,
            interaction_elements,
            constraint_zero_domain,
        );

[alonh5]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 58 at r1 (raw file):

Previously, shaharsamocha7 wrote…

The step constraint is of degree 2, right?

Done.

---

stwo_cairo_prover/src/components/range_check_unit.rs line 94 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Why not adding all the constraints?

All in one PR? It would be harder to review

[shaharsamocha7]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 33 at r2 (raw file):

impl RangeCheckUnitComponent {
    fn evaluate_lookup_boundary_constraints_at_point(

Don't you want to update the eval_at_domain function for the prover in the same pr?

Code quote:

fn evaluate_lookup_boundary_constraints_at_point(

---

stwo_cairo_prover/src/components/range_check_unit.rs line 73 at r2 (raw file):

        point: CirclePoint<SecureField>,
    ) -> TreeVec<ColumnVec<Vec<CirclePoint<SecureField>>>> {
        TreeVec::new(vec![fixed_mask_points(&vec![vec![0_usize]], point)])

didn't you have that with ;2?

Code quote:

fixed_mask_points(&vec![vec![0_usize]

[alonh5]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 33 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Don't you want to update the eval_at_domain function for the prover in the same pr?

It's in the next PR. I can combine them if you prefer.

---

stwo_cairo_prover/src/components/range_check_unit.rs line 73 at r2 (raw file):

Previously, shaharsamocha7 wrote…

didn't you have that with ;2?

Yes, I fixed it in the next PR.

[shaharsamocha7]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

---

stwo_cairo_prover/src/components/range_check_unit.rs line 33 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

It's in the next PR. I can combine them if you prefer.

your call

[alonh5]

Merge activity

• Jul 11, 3:20 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
• Jul 11, 3:25 AM EDT: Graphite rebased this pull request as part of a merge.
• Jul 11, 3:26 AM EDT: @alonh5 merged this pull request with Graphite.