Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup step constraint. #17

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jul 11, 2024

This change is Reviewable

@alonh5 alonh5 force-pushed the 07-10-add_last_lookup_boundary_constraint branch from 52780bc to b7dfa16 Compare July 14, 2024 10:32
@alonh5 alonh5 force-pushed the 07-11-add_lookup_step_constraint branch from ff37f89 to 8dc79b9 Compare July 14, 2024 10:32
@alonh5 alonh5 force-pushed the 07-10-add_last_lookup_boundary_constraint branch from b7dfa16 to c21ea17 Compare July 14, 2024 12:12
@alonh5 alonh5 force-pushed the 07-11-add_lookup_step_constraint branch from 8dc79b9 to a5ff60b Compare July 14, 2024 12:12
@alonh5 alonh5 mentioned this pull request Jul 14, 2024
@alonh5 alonh5 force-pushed the 07-10-add_last_lookup_boundary_constraint branch from c21ea17 to b09c3d4 Compare July 14, 2024 12:24
@alonh5 alonh5 force-pushed the 07-11-add_lookup_step_constraint branch from a5ff60b to 7618445 Compare July 14, 2024 12:24
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)


stwo_cairo_prover/src/components/range_check_unit/component.rs line 207 at r1 (raw file):

            } else {
                (1 << (log_size - 1)) + ((1 << log_size) - 1 - i) / 2
            };

Can we extract this to a function? Maybe in stwo?

Code quote:

            let index = if i & 1 == 0 {
                i / 2
            } else {
                (1 << (log_size - 1)) + ((1 << log_size) - 1 - i) / 2
            };

Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


stwo_cairo_prover/src/components/range_check_unit/component.rs line 207 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Can we extract this to a function? Maybe in stwo?

Yes, done in PR 728 in stwo. ptal :)

@alonh5 alonh5 force-pushed the 07-11-add_lookup_step_constraint branch from 7618445 to f23854f Compare July 15, 2024 07:59
@alonh5 alonh5 changed the base branch from 07-10-add_last_lookup_boundary_constraint to main July 15, 2024 07:59
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5)


stwo_cairo_prover/src/components/range_check_unit/component.rs line 207 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Yes, done in PR 728 in stwo. ptal :)

Great. lgtmed. Now, let's use it here

@alonh5 alonh5 force-pushed the 07-11-add_lookup_step_constraint branch from f23854f to 64e046d Compare July 15, 2024 10:08
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


stwo_cairo_prover/src/components/range_check_unit/component.rs line 207 at r1 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

Great. lgtmed. Now, let's use it here

Done.

Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit a6a5aa0 into main Jul 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants