-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lookup step constraint. #17
Conversation
52780bc
to
b7dfa16
Compare
ff37f89
to
8dc79b9
Compare
b7dfa16
to
c21ea17
Compare
8dc79b9
to
a5ff60b
Compare
c21ea17
to
b09c3d4
Compare
a5ff60b
to
7618445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
stwo_cairo_prover/src/components/range_check_unit/component.rs
line 207 at r1 (raw file):
} else { (1 << (log_size - 1)) + ((1 << log_size) - 1 - i) / 2 };
Can we extract this to a function? Maybe in stwo?
Code quote:
let index = if i & 1 == 0 {
i / 2
} else {
(1 << (log_size - 1)) + ((1 << log_size) - 1 - i) / 2
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
stwo_cairo_prover/src/components/range_check_unit/component.rs
line 207 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Can we extract this to a function? Maybe in stwo?
Yes, done in PR 728 in stwo. ptal :)
7618445
to
f23854f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @alonh5)
stwo_cairo_prover/src/components/range_check_unit/component.rs
line 207 at r1 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Yes, done in PR 728 in stwo. ptal :)
Great. lgtmed. Now, let's use it here
f23854f
to
64e046d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
stwo_cairo_prover/src/components/range_check_unit/component.rs
line 207 at r1 (raw file):
Previously, spapinistarkware (Shahar Papini) wrote…
Great. lgtmed. Now, let's use it here
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
This change is