-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test memory trace. #27
Conversation
9ccea54
to
b88e51d
Compare
564e415
to
54a80f1
Compare
b88e51d
to
ec758ab
Compare
54a80f1
to
e3ec7f8
Compare
ec758ab
to
573d1c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)
stwo_cairo_prover/src/components/memory/component.rs
line 256 at r1 (raw file):
.write_interaction_trace(&trace.iter().collect(), &interaction_elements); let mut trace_sum = SecureField::zero();
rename
Suggestion:
expected_logup_sum
573d1c4
to
f2c1802
Compare
f2c1802
to
941457d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)
stwo_cairo_prover/src/components/memory/component.rs
line 256 at r1 (raw file):
Previously, shaharsamocha7 wrote…
rename
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)
This change is