Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test memory trace. #27

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Test memory trace. #27

merged 1 commit into from
Jul 18, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jul 17, 2024

This change is Reviewable

@alonh5 alonh5 force-pushed the 07-17-test_memory_trace branch from 9ccea54 to b88e51d Compare July 17, 2024 10:33
@alonh5 alonh5 requested review from spapinistarkware and shaharsamocha7 and removed request for spapinistarkware July 17, 2024 10:35
@alonh5 alonh5 force-pushed the 07-16-get_range_check_inputs_one_by_one branch from 564e415 to 54a80f1 Compare July 17, 2024 10:45
@alonh5 alonh5 force-pushed the 07-17-test_memory_trace branch from b88e51d to ec758ab Compare July 17, 2024 10:45
@alonh5 alonh5 force-pushed the 07-16-get_range_check_inputs_one_by_one branch from 54a80f1 to e3ec7f8 Compare July 17, 2024 11:01
@alonh5 alonh5 force-pushed the 07-17-test_memory_trace branch from ec758ab to 573d1c4 Compare July 17, 2024 11:01
Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)


stwo_cairo_prover/src/components/memory/component.rs line 256 at r1 (raw file):

            .write_interaction_trace(&trace.iter().collect(), &interaction_elements);

        let mut trace_sum = SecureField::zero();

rename

Suggestion:

expected_logup_sum

@alonh5 alonh5 force-pushed the 07-17-test_memory_trace branch from 573d1c4 to f2c1802 Compare July 18, 2024 07:23
@alonh5 alonh5 changed the base branch from 07-16-get_range_check_inputs_one_by_one to main July 18, 2024 07:23
@alonh5 alonh5 force-pushed the 07-17-test_memory_trace branch from f2c1802 to 941457d Compare July 18, 2024 07:25
Copy link
Contributor Author

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)


stwo_cairo_prover/src/components/memory/component.rs line 256 at r1 (raw file):

Previously, shaharsamocha7 wrote…

rename

Done.

Copy link
Contributor

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 merged commit 8e5473b into main Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants