Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement memory component prover. #24

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Implement memory component prover. #24

merged 1 commit into from
Jul 17, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented Jul 16, 2024 •
edited by spapinistarkware
Loading

This change is Reviewable

This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@alonh5 Graphite App
Copy link
Contributor Author

alonh5 commented Jul 16, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on Graphite Graphite

This was referenced Jul 16, 2024
Merged
Merged
Merged
Merged
@alonh5 alonh5 requested a review from spapinistarkware July 16, 2024 13:06
spapinistarkware
spapinistarkware approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@spapinistarkware spapinistarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

@alonh5 alonh5 force-pushed the 07-16-write_memory_interaction_trace branch from d107cac to 9bd984f Compare July 17, 2024 08:31
@alonh5 alonh5 force-pushed the 07-16-implement_memory_component_prover branch from 1a3a52f to b4d9e29 Compare July 17, 2024 08:32
@alonh5 alonh5 force-pushed the 07-16-write_memory_interaction_trace branch from 9bd984f to 8df7c47 Compare July 17, 2024 08:48
@alonh5 alonh5 force-pushed the 07-16-implement_memory_component_prover branch from b4d9e29 to 0728191 Compare July 17, 2024 08:48
@alonh5 alonh5 mentioned this pull request Jul 17, 2024
Merged
@alonh5 Graphite App
Copy link
Contributor Author

alonh5 commented Jul 17, 2024 •
edited
Loading

Merge activity

  • Jul 17, 6:36 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
  • Jul 17, 6:44 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 17, 6:44 AM EDT: @alonh5 merged this pull request with Graphite.

@alonh5 alonh5 force-pushed the 07-16-write_memory_interaction_trace branch from 8df7c47 to f53fd6d Compare July 17, 2024 10:40
@alonh5 alonh5 changed the base branch from 07-16-write_memory_interaction_trace to main July 17, 2024 10:42
@alonh5 alonh5 force-pushed the 07-16-implement_memory_component_prover branch from 0728191 to 8e528d0 Compare July 17, 2024 10:43
@alonh5 alonh5 merged commit 5c6a408 into main Jul 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spapinistarkware spapinistarkware spapinistarkware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alonh5 @spapinistarkware