Save inverse on quotient numerator #484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into devAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account in order to use the merge queue. Sign up using this link. |
This was referenced Mar 15, 2024
Merged
Merged
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spapinistarkware and the rest of your teammates on |
This was referenced Mar 15, 2024
Closed
Merged
Merged
Merged
Closed
spapinistarkware
requested review from
alonh5
and removed request for
shaharsamocha7
This was referenced Mar 17, 2024
Merged
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
06aa14c to
a3eac92
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
8a8adca to
4851efd
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
875bc49 to
6e59bf1
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
4851efd to
e96a049
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
6e59bf1 to
c51feb4
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
e96a049 to
32f8918
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
2 times, most recently
from
fc7ccc6 to
19523a9
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
32f8918 to
c876adb
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
19523a9 to
61aeb0d
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
c876adb to
ca143af
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
61aeb0d to
7851448
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
ca143af to
52fc8bd
Compare
andrewmilson
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Reviewed 1 of 3 files at r4, all commit messages.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @spapinistarkware)
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
7851448 to
5fa2762
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
5fa2762 to
736c792
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
52fc8bd to
6d1d5d5
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
2 times, most recently
from
5e3b70f to
4969daf
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
4969daf to
c91c9ca
Compare
spapinistarkware
force-pushed
the
spapini/03-15-save_inverse_on_quotient_numerator
branch
from
6d1d5d5 to
5f6376d
Compare
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
from
c91c9ca to
17ba74a
Compare
andrewmilson
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewed 2 of 3 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
spapinistarkware
force-pushed
the
spapini/03-15-CommitmentSchemeEvalPerSize
branch
3 times, most recently
from
38a3fc8 to
ff9edd3
Compare
alonh5
requested changes
Mar 26, 2024
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
a discussion (no related file):
Can this PR be closed?
I'm changing it for the optimization anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is