Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field debug implementations #501

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Mar 17, 2024

This change is Reviewable

Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 94.60%. Comparing base (fc18b4d) to head (25307db).

Files Patch % Lines
src/core/fields/cm31.rs 0.00% 3 Missing and 1 partial ⚠️
src/core/fields/qm31.rs 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           Commitment_scheme_utils     #501      +/-   ##
===========================================================
- Coverage                    94.67%   94.60%   -0.07%     
===========================================================
  Files                           59       59              
  Lines                         8859     8865       +6     
  Branches                      8859     8865       +6     
===========================================================
  Hits                          8387     8387              
- Misses                         423      429       +6     
  Partials                        49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from 509a841 to 33328a4 Compare March 17, 2024 13:21
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from 2e30850 to e67f607 Compare March 18, 2024 11:51
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 987a089 to 2c63527 Compare March 18, 2024 11:52
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from e67f607 to aa2a0bb Compare March 18, 2024 11:54
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 2c63527 to 0e896ef Compare March 18, 2024 11:54
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from aa2a0bb to bdd9702 Compare March 18, 2024 11:54
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 0e896ef to e3167b0 Compare March 18, 2024 11:54
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch 2 times, most recently from 3cd4d56 to 4e8b8cf Compare March 19, 2024 12:25
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from e3167b0 to c554d7d Compare March 19, 2024 12:25
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from 4e8b8cf to 8d744c3 Compare March 19, 2024 14:01
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from c554d7d to 0bd41d4 Compare March 19, 2024 14:01
Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from 8d744c3 to d05d2b0 Compare March 19, 2024 14:21
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 0bd41d4 to 73f5417 Compare March 19, 2024 14:26
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from d05d2b0 to fc18b4d Compare March 19, 2024 14:38
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 73f5417 to 25307db Compare March 19, 2024 14:38
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from fc18b4d to 31c016e Compare March 19, 2024 14:48
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 25307db to 7d6f270 Compare March 19, 2024 14:48
@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from 31c016e to 7bcfd0e Compare March 19, 2024 14:52
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 7d6f270 to 104bacc Compare March 19, 2024 14:52
Copy link
Contributor Author

spapinistarkware commented Mar 19, 2024

Merge activity

@spapinistarkware spapinistarkware force-pushed the Commitment_scheme_utils branch from 7bcfd0e to 2bb58f2 Compare March 19, 2024 15:12
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 104bacc to 4010dd4 Compare March 19, 2024 15:17
@spapinistarkware spapinistarkware changed the base branch from Commitment_scheme_utils to dev March 19, 2024 15:17
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from 4010dd4 to ce49c72 Compare March 19, 2024 15:18
@spapinistarkware spapinistarkware force-pushed the Field_debug_implementations branch from ce49c72 to 9811cab Compare March 19, 2024 15:18
@spapinistarkware spapinistarkware merged commit 828bdf3 into dev Mar 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants