Add measurement logs

[spapinistarkware]

This change is 

[spapinistarkware]

• parallel wide fib test #511
• Evaluation oods once #496
• Reuse commitment evaluation #495
• Use precomputed twiddles #494
• Add measurement logs #493 👈
• WideFib test with AVX Backend #492
• Make prove() generic in Backend #490 : 1 other dependent PR (#491 )
• CommitmentSchemeProver generic in backend #489
• Fri AVX ops #563
• AVX quotients #488
• Remove old merkle #531 : 1 other dependent PR (#486 )
• FRI using simple merkle #530
• Dumb down FRI #529
• avx merkle #528
• simple merkle benchmark #527
• Use simple merkle tree #526
• merkle intermediate layers #548
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.12%. Comparing base (c8552c4) to head (1b54a8c).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #493   +/-   ##
=======================================
  Coverage   94.11%   94.12%           
=======================================
  Files          66       66           
  Lines        8379     8392   +13     
  Branches     8379     8392   +13     
=======================================
+ Hits         7886     7899   +13     
  Misses        428      428           
  Partials       65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

---

src/examples/wide_fibonacci/avx.rs line 39 at r1 (raw file):

    log_size: usize,
) -> ColumnVec<CircleEvaluation<AVX512Backend, BaseField, BitReversedOrder>> {
    let _span = span!(Level::INFO, "Trace generation").entered();

Can you move it to the caller?

stwo/src/examples/fibonacci/mod.rs

Line 53 in f3da0ed

let trace = self.get_trace();

Code quote:

  let _span = span!(Level::INFO, "Trace generation").entered();

[spapinistarkware]

Reviewable status: 7 of 11 files reviewed, 1 unresolved discussion (waiting on @shaharsamocha7)

---

src/examples/wide_fibonacci/avx.rs line 39 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you move it to the caller?

stwo/src/examples/fibonacci/mod.rs

Line 53 in f3da0ed

let trace = self.get_trace();

Done.

[shaharsamocha7]

Reviewed 4 of 4 files at r2.
Reviewable status: 10 of 11 files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

src/core/commitment_scheme/prover.rs line 163 at r2 (raw file):

        span.exit();

        let _span = span!(Level::INFO, "Commitment merkle").entered();

Why do you need to bind it to a variable?

Code quote:

let _span = 

---

src/examples/wide_fibonacci/avx.rs line 74 at r2 (raw file):

        evaluation_accumulator: &mut DomainEvaluationAccumulator<AVX512Backend>,
    ) {
        let span = span!(Level::INFO, "Constraint eval extension").entered();

This is not just the extension here.

Code quote:

 let span = span!(Level::INFO, "Constraint eval extension").entered();

---

src/examples/wide_fibonacci/avx.rs line 170 at r3 (raw file):

    fn test_avx_wide_fib_prove() {
        // Note: To see time measurement, run test with
        //   RUST_LOG_SPAN_EVENTS=enter,close RUST_LOG=info RUST_BACKTRACE=1 RUSTFLAGS="-Awarnings

Why do you have warnings here?

Code quote:

RUSTFLAGS="-Awarnings

[spapinistarkware]

Reviewable status: 10 of 11 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

---

src/core/commitment_scheme/prover.rs line 163 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Why do you need to bind it to a variable?

I think it's more consistent with the let span= calls.

---

src/examples/wide_fibonacci/avx.rs line 74 at r2 (raw file):

Previously, shaharsamocha7 wrote…

This is not just the extension here.

Done.

---

src/examples/wide_fibonacci/avx.rs line 170 at r3 (raw file):

Previously, shaharsamocha7 wrote…

Why do you have warnings here?

Done.

[shaharsamocha7]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[spapinistarkware]

Merge activity

• Apr 15, 7:31 AM EDT: @spapinistarkware started a stack merge that includes this pull request via Graphite.
• Apr 15, 7:31 AM EDT: @spapinistarkware merged this pull request with Graphite.