-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old merkle #531
Remove old merkle #531
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spapinistarkware and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spapini/03-22-fri_using_simple_merkle #531 +/- ##
=========================================================================
- Coverage 94.23% 93.11% -1.13%
=========================================================================
Files 68 62 -6
Lines 10239 8048 -2191
Branches 10239 8048 -2191
=========================================================================
- Hits 9649 7494 -2155
+ Misses 520 493 -27
+ Partials 70 61 -9 ☔ View full report in Codecov by Sentry. |
f84b72a
to
cd39c4c
Compare
f643356
to
31c3030
Compare
cd39c4c
to
a1b0d69
Compare
31c3030
to
f7586f2
Compare
a1b0d69
to
7022e25
Compare
f7586f2
to
d531d45
Compare
7022e25
to
f56de3a
Compare
d531d45
to
87488bb
Compare
f56de3a
to
7bbe8cc
Compare
87488bb
to
78cf3ac
Compare
7bbe8cc
to
841c5c1
Compare
78cf3ac
to
0b3e4d2
Compare
841c5c1
to
86c68f3
Compare
0b3e4d2
to
92eed0a
Compare
86c68f3
to
d677bbc
Compare
92eed0a
to
fb7b8d9
Compare
d677bbc
to
c797897
Compare
fb7b8d9
to
331c202
Compare
c797897
to
10c3379
Compare
331c202
to
479f35b
Compare
70135cc
to
bc09891
Compare
3bb9e12
to
71d5bcd
Compare
bc09891
to
f3a6b77
Compare
71d5bcd
to
6c8bd79
Compare
f3a6b77
to
e93b1e3
Compare
6c8bd79
to
a888111
Compare
e93b1e3
to
a3f9dca
Compare
a888111
to
09e354d
Compare
a3f9dca
to
4c7ebda
Compare
9537da3
to
a16f7fe
Compare
4c7ebda
to
95a2e0a
Compare
a16f7fe
to
5589dfc
Compare
95a2e0a
to
c36d122
Compare
5589dfc
to
f04e4dc
Compare
f04e4dc
to
be29c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 15 files at r1, 4 of 13 files at r2, all commit messages.
Reviewable status: 6 of 21 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 15 files at r1, 9 of 13 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)
src/examples/fibonacci/mod.rs
line 131 at r3 (raw file):
use crate::{m31, qm31}; pub fn generate_test_queries(n_queries: usize, trace_length: usize) -> Vec<usize> {
:(
Suggestion:
#[cfg(test)]
pub fn generate_test_queries(n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)
Merge activity
|
This change is