Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old merkle #531

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Remove old merkle #531

merged 2 commits into from
Apr 3, 2024

Conversation

spapinistarkware
Copy link
Contributor

@spapinistarkware spapinistarkware commented Mar 22, 2024

This change is Reviewable

Copy link
Contributor Author

spapinistarkware commented Mar 22, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (c36d122) to head (f04e4dc).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           spapini/03-22-fri_using_simple_merkle     #531      +/-   ##
=========================================================================
- Coverage                                  94.23%   93.11%   -1.13%     
=========================================================================
  Files                                         68       62       -6     
  Lines                                      10239     8048    -2191     
  Branches                                   10239     8048    -2191     
=========================================================================
- Hits                                        9649     7494    -2155     
+ Misses                                       520      493      -27     
+ Partials                                      70       61       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from f84b72a to cd39c4c Compare March 24, 2024 13:48
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from f643356 to 31c3030 Compare March 24, 2024 13:48
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from cd39c4c to a1b0d69 Compare March 24, 2024 14:25
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 31c3030 to f7586f2 Compare March 24, 2024 14:25
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from a1b0d69 to 7022e25 Compare March 24, 2024 14:30
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from f7586f2 to d531d45 Compare March 24, 2024 14:30
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 7022e25 to f56de3a Compare March 24, 2024 15:07
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from d531d45 to 87488bb Compare March 24, 2024 15:07
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from f56de3a to 7bbe8cc Compare March 25, 2024 05:20
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 87488bb to 78cf3ac Compare March 25, 2024 05:20
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 7bbe8cc to 841c5c1 Compare March 25, 2024 06:09
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 78cf3ac to 0b3e4d2 Compare March 25, 2024 06:09
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 841c5c1 to 86c68f3 Compare March 25, 2024 06:14
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 0b3e4d2 to 92eed0a Compare March 25, 2024 06:14
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 86c68f3 to d677bbc Compare March 25, 2024 06:28
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 92eed0a to fb7b8d9 Compare March 25, 2024 06:28
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from d677bbc to c797897 Compare March 25, 2024 09:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from fb7b8d9 to 331c202 Compare March 25, 2024 09:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from c797897 to 10c3379 Compare March 25, 2024 12:00
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 331c202 to 479f35b Compare March 25, 2024 12:00
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 70135cc to bc09891 Compare March 28, 2024 09:43
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 3bb9e12 to 71d5bcd Compare March 28, 2024 09:43
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from bc09891 to f3a6b77 Compare April 2, 2024 11:26
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 71d5bcd to 6c8bd79 Compare April 2, 2024 11:26
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from f3a6b77 to e93b1e3 Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 6c8bd79 to a888111 Compare April 3, 2024 06:22
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from e93b1e3 to a3f9dca Compare April 3, 2024 06:45
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from a888111 to 09e354d Compare April 3, 2024 06:45
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from a3f9dca to 4c7ebda Compare April 3, 2024 06:49
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch 2 times, most recently from 9537da3 to a16f7fe Compare April 3, 2024 08:06
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 4c7ebda to 95a2e0a Compare April 3, 2024 10:55
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from a16f7fe to 5589dfc Compare April 3, 2024 10:55
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-fri_using_simple_merkle branch from 95a2e0a to c36d122 Compare April 3, 2024 11:45
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from 5589dfc to f04e4dc Compare April 3, 2024 11:46
@spapinistarkware spapinistarkware mentioned this pull request Apr 3, 2024
@spapinistarkware spapinistarkware force-pushed the spapini/03-22-remove_old_merkle branch from f04e4dc to be29c98 Compare April 3, 2024 12:46
@spapinistarkware spapinistarkware changed the base branch from spapini/03-22-fri_using_simple_merkle to dev April 3, 2024 12:46
Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 15 files at r1, 4 of 13 files at r2, all commit messages.
Reviewable status: 6 of 21 files reviewed, all discussions resolved

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 15 files at r1, 9 of 13 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)


src/examples/fibonacci/mod.rs line 131 at r3 (raw file):

    use crate::{m31, qm31};

    pub fn generate_test_queries(n_queries: usize, trace_length: usize) -> Vec<usize> {

:(

Suggestion:

#[cfg(test)]
pub fn generate_test_queries(n

Copy link
Collaborator

@shaharsamocha7 shaharsamocha7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

Copy link
Contributor Author

spapinistarkware commented Apr 3, 2024

Merge activity

@spapinistarkware spapinistarkware merged commit f3da0ed into dev Apr 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants